Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-08 Thread Pierre Morel
On 2/7/23 19:26, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: S390x provides two more topology containers above the sockets, books and drawers. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel --- qapi

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-07 Thread Nina Schoetterl-Glausch
On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: > S390x provides two more topology containers above the sockets, > books and drawers. > > Let's add these CPU attributes to the QAPI command query-cpu-fast. > > Signed-off-by: Pierre Morel > --- > qapi/machine.json | 13 ++-

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-07 Thread Thomas Huth
On 06/02/2023 15.50, Daniel P. Berrangé wrote: On Mon, Feb 06, 2023 at 02:09:57PM +0100, Thomas Huth wrote: On 06/02/2023 13.49, Daniel P. Berrangé wrote: On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote: On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology con

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Daniel P . Berrangé
On Mon, Feb 06, 2023 at 02:09:57PM +0100, Thomas Huth wrote: > On 06/02/2023 13.49, Daniel P. Berrangé wrote: > > On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote: > > > On 01/02/2023 14.20, Pierre Morel wrote: > > > > S390x provides two more topology containers above the sockets, > > >

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Pierre Morel
On 2/6/23 13:49, Daniel P. Berrangé wrote: On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote: On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology containers above the sockets, books and drawers. Let's add these CPU attributes to the QAPI command query-cpu-fas

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Pierre Morel
On 2/6/23 13:38, Thomas Huth wrote: On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology containers above the sockets, books and drawers. books and drawers are already handled via the entries in CpuInstanceProperties, so this sentence looks like a wrong leftover now?

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Thomas Huth
On 06/02/2023 13.49, Daniel P. Berrangé wrote: On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote: On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology containers above the sockets, books and drawers. Let's add these CPU attributes to the QAPI command query-cpu-fa

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Daniel P . Berrangé
On Mon, Feb 06, 2023 at 01:41:44PM +0100, Thomas Huth wrote: > On 01/02/2023 14.20, Pierre Morel wrote: > > S390x provides two more topology containers above the sockets, > > books and drawers. > > > > Let's add these CPU attributes to the QAPI command query-cpu-fast. > > > > Signed-off-by: Pierr

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Thomas Huth
On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology containers above the sockets, books and drawers. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel --- qapi/machine.json | 13 ++--- hw/core/machine-qmp-cm

Re: [PATCH v15 09/11] machine: adding s390 topology to query-cpu-fast

2023-02-06 Thread Thomas Huth
On 01/02/2023 14.20, Pierre Morel wrote: S390x provides two more topology containers above the sockets, books and drawers. books and drawers are already handled via the entries in CpuInstanceProperties, so this sentence looks like a wrong leftover now? I'd suggest talking about "dedication"