Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2024-08-28 Thread Gerd Hoffmann
Hi, > But I think unexpected access shouldn't be there in the 1st place, > so guard looks pretty legit at this point. > Lets see what Gerd finds out from edk2 point of view. CPU eject happens /after/ SMM syncronisation, when CPUs are on their way back into normal mode: * The boot processor wi

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2024-08-27 Thread Igor Mammedov
On Wed, 21 Aug 2024 15:25:18 +0200 Igor Mammedov wrote: > On Thu, 27 Apr 2023 17:10:06 -0400 > Alexander Bulekov wrote: > > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > > This flag is set/checked prior to calling a device's MemoryRegion > > handlers, and set when

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2024-08-21 Thread Igor Mammedov
On Thu, 27 Apr 2023 17:10:06 -0400 Alexander Bulekov wrote: > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > This flag is set/checked prior to calling a device's MemoryRegion > handlers, and set when device code initiates DMA. The purpose of this > flag is to prevent

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-11 Thread Song Gao
在 2023/5/11 下午4:58, Thomas Huth 写道: On 11/05/2023 10.53, Song Gao wrote: ... And Should we need add  '  @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')' ? I see some tests add this. No, please don't add that unless there is a good reason. That marker is only required if the test do

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-11 Thread Thomas Huth
On 11/05/2023 10.53, Song Gao wrote: ... And Should we need add  '  @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')' ? I see some tests add this. No, please don't add that unless there is a good reason. That marker is only required if the test does not work reliable on gitlab, e.g. if it

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-11 Thread Song Gao
在 2023/5/10 下午8:21, Thomas Huth 写道: On 10/05/2023 11.02, Song Gao wrote: Hi, Thomas 在 2023/5/8 下午9:12, Thomas Huth 写道: Oh, another spot that needs special handling ... I see Alexander already sent a patch (thanks!), but anyway, this is a good indication that we're missing some test cover

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-10 Thread Thomas Huth
On 10/05/2023 11.02, Song Gao wrote: Hi, Thomas 在 2023/5/8 下午9:12, Thomas Huth 写道: Oh, another spot that needs special handling ... I see Alexander already sent a patch (thanks!), but anyway, this is a good indication that we're missing some test coverage in the CI. Are there any loongarch

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-10 Thread Song Gao
Hi, Thomas 在 2023/5/8 下午9:12, Thomas Huth 写道: Oh, another spot that needs special handling ... I see Alexander already sent a patch (thanks!), but anyway, this is a good indication that we're missing some test coverage in the CI. Are there any loongarch kernel images available for public do

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-08 Thread Song Gao
在 2023/5/8 下午9:12, Thomas Huth 写道: On 08/05/2023 15.03, Song Gao wrote: Hi, Thomas 在 2023/5/8 下午5:33, Thomas Huth 写道: On 06/05/2023 11.25, Song Gao wrote:   Hi Alexander 在 2023/4/28 下午5:14, Thomas Huth 写道: On 28/04/2023 11.11, Alexander Bulekov wrote: On 230428 1015, Thomas Huth wrote:

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-08 Thread Thomas Huth
On 08/05/2023 15.03, Song Gao wrote: Hi, Thomas 在 2023/5/8 下午5:33, Thomas Huth 写道: On 06/05/2023 11.25, Song Gao wrote:   Hi Alexander 在 2023/4/28 下午5:14, Thomas Huth 写道: On 28/04/2023 11.11, Alexander Bulekov wrote: On 230428 1015, Thomas Huth wrote: On 28/04/2023 10.12, Daniel P. Berrang

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-08 Thread Song Gao
Hi, Thomas 在 2023/5/8 下午5:33, Thomas Huth 写道: On 06/05/2023 11.25, Song Gao wrote:   Hi Alexander 在 2023/4/28 下午5:14, Thomas Huth 写道: On 28/04/2023 11.11, Alexander Bulekov wrote: On 230428 1015, Thomas Huth wrote: On 28/04/2023 10.12, Daniel P. Berrangé wrote: On Thu, Apr 27, 2023 at 05:1

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-08 Thread Thomas Huth
On 06/05/2023 11.25, Song Gao wrote:  Hi Alexander 在 2023/4/28 下午5:14, Thomas Huth 写道: On 28/04/2023 11.11, Alexander Bulekov wrote: On 230428 1015, Thomas Huth wrote: On 28/04/2023 10.12, Daniel P. Berrangé wrote: On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote: Add a fl

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-06 Thread Song Gao
 Hi Alexander 在 2023/4/28 下午5:14, Thomas Huth 写道: On 28/04/2023 11.11, Alexander Bulekov wrote: On 230428 1015, Thomas Huth wrote: On 28/04/2023 10.12, Daniel P. Berrangé wrote: On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote: Add a flag to the DeviceState, when a device is

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-04-28 Thread Thomas Huth
On 28/04/2023 11.11, Alexander Bulekov wrote: On 230428 1015, Thomas Huth wrote: On 28/04/2023 10.12, Daniel P. Berrangé wrote: On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote: Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked p

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-04-28 Thread Alexander Bulekov
On 230428 1015, Thomas Huth wrote: > On 28/04/2023 10.12, Daniel P. Berrangé wrote: > > On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote: > > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > > > This flag is set/checked prior to calling a device's Memory

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-04-28 Thread Thomas Huth
On 28/04/2023 10.12, Daniel P. Berrangé wrote: On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote: Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked prior to calling a device's MemoryRegion handlers, and set when device code initiate

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-04-28 Thread Daniel P . Berrangé
On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote: > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > This flag is set/checked prior to calling a device's MemoryRegion > handlers, and set when device code initiates DMA. The purpose of this > flag is to pre

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-04-27 Thread Thomas Huth
On 27/04/2023 23.10, Alexander Bulekov wrote: Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked prior to calling a device's MemoryRegion handlers, and set when device code initiates DMA. The purpose of this flag is to prevent two types of DMA-based