Re: [PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-03 Thread Alex Bennée
Robert Foley writes: > On Wed, 3 Jun 2020 at 07:43, Alex Bennée wrote: >> >> >> Robert Foley writes: >> > >> > >> > When testing out the options, I noticed that >> > if we supply arguments of "read", and "write", then we will only get >> > the last one set, "write", since rw gets overwritten

Re: [PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-03 Thread Alex Bennée
Peter Maydell writes: > On Tue, 2 Jun 2020 at 16:54, Alex Bennée wrote: >> >> This is a plugin intended to help with profiling access to various >> bits of system hardware. It only really makes sense for system >> emulation. >> >> It takes advantage of the recently exposed helper API that allo

Re: [PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-03 Thread Peter Maydell
On Tue, 2 Jun 2020 at 16:54, Alex Bennée wrote: > > This is a plugin intended to help with profiling access to various > bits of system hardware. It only really makes sense for system > emulation. > > It takes advantage of the recently exposed helper API that allows us > to see the device name (me

Re: [PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-03 Thread Robert Foley
On Wed, 3 Jun 2020 at 07:43, Alex Bennée wrote: > > > Robert Foley writes: > > > > > When testing out the options, I noticed that > > if we supply arguments of "read", and "write", then we will only get > > the last one set, "write", since rw gets overwritten. > > One option would be to error ou

Re: [PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-03 Thread Alex Bennée
Robert Foley writes: > Hi, > > On Tue, 2 Jun 2020 at 11:46, Alex Bennée wrote: > >> diff --git a/tests/plugin/hwprofile.c b/tests/plugin/hwprofile.c >> new file mode 100644 >> index 000..f5e0639e762 >> --- /dev/null >> +++ b/tests/plugin/hwprofile.c > >> +static void vcpu_haddr(unsig

Re: [PATCH v1 8/9] plugins: new hwprofile plugin

2020-06-02 Thread Robert Foley
Hi, On Tue, 2 Jun 2020 at 11:46, Alex Bennée wrote: > diff --git a/tests/plugin/hwprofile.c b/tests/plugin/hwprofile.c > new file mode 100644 > index 000..f5e0639e762 > --- /dev/null > +++ b/tests/plugin/hwprofile.c > +static void vcpu_haddr(unsigned int cpu_index, qemu_plugin_meminfo_t