Re: [PATCH v1 3/8] s390/sclp: rework sclp boundary and length checks

2020-05-14 Thread Collin Walling
On 5/13/20 3:00 AM, Cornelia Huck wrote: > On Tue, 12 May 2020 10:55:56 -0400 > Collin Walling wrote: > >> On 5/12/20 3:21 AM, David Hildenbrand wrote: >>> On 09.05.20 01:08, Collin Walling wrote: > +static bool check_sufficient_sccb_len(SCCB *sccb, int size) >>> >>> "has_sufficient_scc

Re: [PATCH v1 3/8] s390/sclp: rework sclp boundary and length checks

2020-05-13 Thread Cornelia Huck
On Tue, 12 May 2020 10:55:56 -0400 Collin Walling wrote: > On 5/12/20 3:21 AM, David Hildenbrand wrote: > > On 09.05.20 01:08, Collin Walling wrote: > >> +static bool check_sufficient_sccb_len(SCCB *sccb, int size) > > > > "has_sufficient_sccb_len" ? > > > >> +{ > >> +MachineState *m

Re: [PATCH v1 3/8] s390/sclp: rework sclp boundary and length checks

2020-05-12 Thread Collin Walling
On 5/12/20 3:21 AM, David Hildenbrand wrote: On 09.05.20 01:08, Collin Walling wrote: Let's factor out the SCLP boundary and length checks into separate functions. Signed-off-by: Collin Walling --- hw/s390x/sclp.c | 41 +++-- 1 file changed, 35 insertions

Re: [PATCH v1 3/8] s390/sclp: rework sclp boundary and length checks

2020-05-12 Thread David Hildenbrand
On 09.05.20 01:08, Collin Walling wrote: > Let's factor out the SCLP boundary and length checks > into separate functions. > > Signed-off-by: Collin Walling > --- > hw/s390x/sclp.c | 41 +++-- > 1 file changed, 35 insertions(+), 6 deletions(-) > > diff --git