Re: [PATCH v1 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-01-31 Thread Edgar E. Iglesias
On Mon, Jan 31, 2022 at 06:27:09PM +0100, Edgar E. Iglesias wrote: > On Mon, Jan 31, 2022 at 03:35:57PM +, Francisco Iglesias wrote: > > Hi Edgar, > > > > A couple of minor comments below, looks good to me otherwise! > > > > On Mon, Jan 31, 2022 at 12:12:03AM +0100, Edgar E. Iglesias wrote: >

Re: [PATCH v1 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-01-31 Thread Edgar E. Iglesias
On Mon, Jan 31, 2022 at 03:35:57PM +, Francisco Iglesias wrote: > Hi Edgar, > > A couple of minor comments below, looks good to me otherwise! > > On Mon, Jan 31, 2022 at 12:12:03AM +0100, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add a model of the Xilinx ZynqMP CRF. At

Re: [PATCH v1 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-01-31 Thread Francisco Iglesias
Hi Edgar, A couple of minor comments below, looks good to me otherwise! On Mon, Jan 31, 2022 at 12:12:03AM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add a model of the Xilinx ZynqMP CRF. At the moment this > is mostly a stub model. > > Signed-off-by: Edgar E. Iglesias >

Re: [PATCH v1 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-01-30 Thread Philippe Mathieu-Daudé via
On 31/1/22 00:12, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add a model of the Xilinx ZynqMP CRF. At the moment this is mostly a stub model. Signed-off-by: Edgar E. Iglesias --- include/hw/misc/xlnx-zynqmp-crf.h | 209 +++ hw/misc/xlnx-zynqmp-crf.c | 27