Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-10-04 Thread John Snow
On Wed, Oct 4, 2023, 8:43 AM Victor Toso wrote: > Hi, > > On Mon, Oct 02, 2023 at 04:09:29PM -0400, John Snow wrote: > > On Mon, Oct 2, 2023 at 3:07 PM John Snow wrote: > > > > > > On Wed, Sep 27, 2023 at 7:25 AM Victor Toso > wrote: > > > > > > > > This patch handles QAPI enum types and genera

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-10-04 Thread Victor Toso
Hi, On Mon, Oct 02, 2023 at 04:09:29PM -0400, John Snow wrote: > On Mon, Oct 2, 2023 at 3:07 PM John Snow wrote: > > > > On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > > > > > This patch handles QAPI enum types and generates its equivalent in Go. > > > > > > Basically, Enums are being ha

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-10-04 Thread Victor Toso
Hi, On Mon, Oct 02, 2023 at 03:07:49PM -0400, John Snow wrote: > On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > > > This patch handles QAPI enum types and generates its equivalent in Go. > > > > Basically, Enums are being handled as strings in Golang. > > > > 1. For each QAPI enum, we wil

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-10-02 Thread John Snow
On Mon, Oct 2, 2023 at 3:07 PM John Snow wrote: > > On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > > > This patch handles QAPI enum types and generates its equivalent in Go. > > > > Basically, Enums are being handled as strings in Golang. > > > > 1. For each QAPI enum, we will define a st

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-10-02 Thread John Snow
On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > This patch handles QAPI enum types and generates its equivalent in Go. > > Basically, Enums are being handled as strings in Golang. > > 1. For each QAPI enum, we will define a string type in Go to be the >assigned type of this specific enu

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-09-29 Thread Victor Toso
Hi, On Thu, Sep 28, 2023 at 02:52:08PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 27, 2023 at 01:25:36PM +0200, Victor Toso wrote: > > This patch handles QAPI enum types and generates its equivalent in Go. > > > > Basically, Enums are being handled as strings in Golang. > > > > 1. For each Q

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-09-28 Thread Daniel P . Berrangé
On Thu, Sep 28, 2023 at 04:20:55PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Sep 27, 2023 at 01:25:36PM +0200, Victor Toso wrote: > >> This patch handles QAPI enum types and generates its equivalent in Go. > >> > >> Basically, Enums are being handled as strings i

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-09-28 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 27, 2023 at 01:25:36PM +0200, Victor Toso wrote: >> This patch handles QAPI enum types and generates its equivalent in Go. >> >> Basically, Enums are being handled as strings in Golang. >> >> 1. For each QAPI enum, we will define a string type in Go to b

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

2023-09-28 Thread Daniel P . Berrangé
On Wed, Sep 27, 2023 at 01:25:36PM +0200, Victor Toso wrote: > This patch handles QAPI enum types and generates its equivalent in Go. > > Basically, Enums are being handled as strings in Golang. > > 1. For each QAPI enum, we will define a string type in Go to be the >assigned type of this spe