Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread Peter Xu
On Fri, Feb 21, 2020 at 11:19:58AM +0100, David Hildenbrand wrote: [...] > Lol, man this code is confusing. (Yes in many places it is...) > > So, migration_is_idle() really only checks current_migration, not > current_incoming. > > I didn't expect to be knees deep in migration code at this po

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 16:40, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 21.02.20 16:14, Dr. David Alan Gilbert wrote: >>> * David Hildenbrand (da...@redhat.com) wrote: Resizing while migrating is dangerous and does not work as expected. The whole migration c

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 21.02.20 16:14, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> Resizing while migrating is dangerous and does not work as expected. > >> The whole migration code works on the usable_length of ram blocks and doe

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 16:14, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> Resizing while migrating is dangerous and does not work as expected. >> The whole migration code works on the usable_length of ram blocks and does >> not expect this to change at random points in tim

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > Resizing while migrating is dangerous and does not work as expected. > The whole migration code works on the usable_length of ram blocks and does > not expect this to change at random points in time. > > In the case of precopy, the ram block size mus

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 11:10, David Hildenbrand wrote: > On 21.02.20 10:18, David Hildenbrand wrote: >> On 20.02.20 21:17, Peter Xu wrote: >>> On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: On 19.02.20 17:17, David Hildenbrand wrote: > Resizing while migrating is dangerous and doe

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 10:18, David Hildenbrand wrote: > On 20.02.20 21:17, Peter Xu wrote: >> On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: >>> On 19.02.20 17:17, David Hildenbrand wrote: Resizing while migrating is dangerous and does not work as expected. The whole migration c

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 20.02.20 21:17, Peter Xu wrote: > On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: >> On 19.02.20 17:17, David Hildenbrand wrote: >>> Resizing while migrating is dangerous and does not work as expected. >>> The whole migration code works on the usable_length of ram blocks and d

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-20 Thread Peter Xu
On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: > On 19.02.20 17:17, David Hildenbrand wrote: > > Resizing while migrating is dangerous and does not work as expected. > > The whole migration code works on the usable_length of ram blocks and does > > not expect this to change at r

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-20 Thread David Hildenbrand
On 19.02.20 17:17, David Hildenbrand wrote: > Resizing while migrating is dangerous and does not work as expected. > The whole migration code works on the usable_length of ram blocks and does > not expect this to change at random points in time. > > In the case of precopy, the ram block size must