On 1/17/20 10:43 PM, Cameron Esfahani via wrote:
I’m new to this process, what are the next steps?
Assuming your patch is in a branch named vncfix_v1:
1/ Start new branch based on the commit previous to your patch:
- git checkout -b vncfix_v2 vncfix_v1~
2/ Revert the offending patch, expla
I’m new to this process, what are the next steps?
Cameron Esfahani
di...@apple.com
> On Jan 16, 2020, at 11:47 PM, Gerd Hoffmann wrote:
>
> On Thu, Jan 16, 2020 at 07:50:58PM -0800, Cameron Esfahani wrote:
>> Remove VNC optimization to reencode framebuffer update as raw if it's
>> smaller than
Yes. Personally, I'd also take the change to vnc-enc-zrle.c: because
vs->zrle->zlib is reset at the top of the function, using vs->zrle->zlib.offset
in determining zstream->next_out and zstream->avail_out is useless.
Cameron Esfahani
di...@apple.com
"All that is necessary for the triumph of ev
On Thu, Jan 16, 2020 at 07:50:58PM -0800, Cameron Esfahani wrote:
> Remove VNC optimization to reencode framebuffer update as raw if it's
> smaller than the default encoding. QEMU's implementation was naive and
> didn't account for the ZLIB z_stream mutating with each compression. Just
> saving a
