Re: [PATCH for-8.1] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-10-10 Thread Thomas Huth
On 25/07/2023 13.36, Peter Maydell wrote: In query_port() we pass the address of a local pvrdma_port_attr struct to the rdma_query_backend_port() function. Unfortunately, rdma_backend_query_port() wants a pointer to a struct ibv_port_attr, and the two are not the same length. Coverity spotted t

Re: [PATCH for-8.1] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-09-23 Thread Michael Tokarev
22.09.2023 18:05, Thomas Huth wrote: Reviewed-by: Thomas Huth Maybe this could go via qemu-trivial? On 12/09/2023 16.08, Peter Maydell wrote: Ping^2 for review/pickup by the rdma folks, please? Is anybody still using this subsystem? ... if not, then it's maybe time to set this on the depr

Re: [PATCH for-8.1] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-09-22 Thread Thomas Huth
Reviewed-by: Thomas Huth Maybe this could go via qemu-trivial? On 12/09/2023 16.08, Peter Maydell wrote: Ping^2 for review/pickup by the rdma folks, please? Is anybody still using this subsystem? ... if not, then it's maybe time to set this on the deprecation list? ... just my 0.02 €.

Re: [PATCH for-8.1] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-09-12 Thread Peter Maydell
Ping^2 for review/pickup by the rdma folks, please? thanks -- PMM On Tue, 29 Aug 2023 at 16:49, Peter Maydell wrote: > > On Tue, 25 Jul 2023 at 12:36, Peter Maydell wrote: > > > > In query_port() we pass the address of a local pvrdma_port_attr > > struct to the rdma_query_backend_port() functio

Re: [PATCH for-8.1] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-08-29 Thread Peter Maydell
On Tue, 25 Jul 2023 at 12:36, Peter Maydell wrote: > > In query_port() we pass the address of a local pvrdma_port_attr > struct to the rdma_query_backend_port() function. Unfortunately, > rdma_backend_query_port() wants a pointer to a struct ibv_port_attr, > and the two are not the same length. >

Re: [PATCH for-8.1] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-07-25 Thread Philippe Mathieu-Daudé
On 25/7/23 13:36, Peter Maydell wrote: In query_port() we pass the address of a local pvrdma_port_attr struct to the rdma_query_backend_port() function. Unfortunately, rdma_backend_query_port() wants a pointer to a struct ibv_port_attr, and the two are not the same length. Coverity spotted this