Re: [PATCH for-6.2 v2 10/11] machine: Split out the smp parsing code

2021-07-22 Thread wangyanan (Y)
On 2021/7/22 21:07, Andrew Jones wrote: On Thu, Jul 22, 2021 at 02:24:03PM +0800, wangyanan (Y) wrote: On 2021/7/20 1:20, Andrew Jones wrote: On Mon, Jul 19, 2021 at 11:20:42AM +0800, Yanan Wang wrote: We are going to introduce an unit test for the parser smp_parse() in hw/core/machine.c, but

Re: [PATCH for-6.2 v2 10/11] machine: Split out the smp parsing code

2021-07-22 Thread Andrew Jones
On Thu, Jul 22, 2021 at 02:24:03PM +0800, wangyanan (Y) wrote: > On 2021/7/20 1:20, Andrew Jones wrote: > > On Mon, Jul 19, 2021 at 11:20:42AM +0800, Yanan Wang wrote: > > > We are going to introduce an unit test for the parser smp_parse() > > > in hw/core/machine.c, but now machine.c is only built

Re: [PATCH for-6.2 v2 10/11] machine: Split out the smp parsing code

2021-07-21 Thread wangyanan (Y)
On 2021/7/20 1:20, Andrew Jones wrote: On Mon, Jul 19, 2021 at 11:20:42AM +0800, Yanan Wang wrote: We are going to introduce an unit test for the parser smp_parse() in hw/core/machine.c, but now machine.c is only built in softmmu. In order to solve the build dependency on the smp parsing code a

Re: [PATCH for-6.2 v2 10/11] machine: Split out the smp parsing code

2021-07-19 Thread Andrew Jones
On Mon, Jul 19, 2021 at 11:20:42AM +0800, Yanan Wang wrote: > We are going to introduce an unit test for the parser smp_parse() > in hw/core/machine.c, but now machine.c is only built in softmmu. > > In order to solve the build dependency on the smp parsing code and > avoid building unrelated stuf