Re: [PATCH for-6.2 20/34] target/arm: Implement MVE integer min/max across vector

2021-07-20 Thread Peter Maydell
On Mon, 19 Jul 2021 at 16:28, Peter Maydell wrote: > > On Sat, 17 Jul 2021 at 21:46, Richard Henderson > wrote: > > > > On 7/13/21 6:37 AM, Peter Maydell wrote: > > > +/* Max and min of absolute values */ > > > +static int64_t do_maxa(int64_t n, int64_t m) > > > +{ > > > +if (n < 0) { > > > +

Re: [PATCH for-6.2 20/34] target/arm: Implement MVE integer min/max across vector

2021-07-19 Thread Peter Maydell
On Sat, 17 Jul 2021 at 21:46, Richard Henderson wrote: > > On 7/13/21 6:37 AM, Peter Maydell wrote: > > +/* Max and min of absolute values */ > > +static int64_t do_maxa(int64_t n, int64_t m) > > +{ > > +if (n < 0) { > > +n = -n; > > +} > > +if (m < 0) { > > +m = -m; >

Re: [PATCH for-6.2 20/34] target/arm: Implement MVE integer min/max across vector

2021-07-17 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: +/* Max and min of absolute values */ +static int64_t do_maxa(int64_t n, int64_t m) +{ +if (n < 0) { +n = -n; +} +if (m < 0) { +m = -m; +} +return MAX(n, m); +} This doesn't look quite right. The n operand is extracte