Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

2020-11-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 03/11/20 17:08, Daniel P. Berrangé wrote: >>> +Short-form boolean options (since 5.2) >>> +'' >>> + >>> +Boolean options such as ``share=on``/``share=off`` can be written >>> +in short form as ``share`` and ``noshare``. This is depre

Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

2020-11-04 Thread Igor Mammedov
On Tue, 3 Nov 2020 22:41:40 +0100 Paolo Bonzini wrote: > On 03/11/20 22:22, Igor Mammedov wrote: > > shall we also deprecate short forms for -cpu model,[feat|+feat|-feat] > > and in the end allow only -device compatible form i.e. -cpu > > type,feat=[on|off] > > > > that would let us drop custom

Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

2020-11-03 Thread Paolo Bonzini
On 03/11/20 22:22, Igor Mammedov wrote: shall we also deprecate short forms for -cpu model,[feat|+feat|-feat] and in the end allow only -device compatible form i.e. -cpu type,feat=[on|off] that would let us drop custom x86_cpu_parse_featurestr, ppc_cpu_parse_featurestr, sparc_cpu_parse_

Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

2020-11-03 Thread Igor Mammedov
On Tue, 3 Nov 2020 16:08:43 + Daniel P. Berrangé wrote: > On Tue, Nov 03, 2020 at 10:14:52AM -0500, Paolo Bonzini wrote: > > Options such as "server" or "nowait", that are commonly found in -chardev, > > are sugar for "server=on" and "wait=off". This is quite surprising and > > also does not

Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

2020-11-03 Thread Paolo Bonzini
On 03/11/20 17:08, Daniel P. Berrangé wrote: >> +Short-form boolean options (since 5.2) >> +'' >> + >> +Boolean options such as ``share=on``/``share=off`` can be written >> +in short form as ``share`` and ``noshare``. This is deprecated >> +for all command-line

Re: [PATCH for-5.2 4/4] qemu-option: warn for short-form boolean options

2020-11-03 Thread Daniel P . Berrangé
On Tue, Nov 03, 2020 at 10:14:52AM -0500, Paolo Bonzini wrote: > Options such as "server" or "nowait", that are commonly found in -chardev, > are sugar for "server=on" and "wait=off". This is quite surprising and > also does not have any notion of typing attached. It is even possible to > do "-de