Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-06-02 Thread John Snow
On 6/2/20 6:26 AM, Kevin Wolf wrote: > I think I prefer the explicit Dict[str, Any] because it doesn't end up > duplicating the default value, but I just wanted to mention that this > option exists, too. Oh, I see what's going on here now! Thanks, that's very helpful! In this case, for now, I t

Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-06-02 Thread Kevin Wolf
Am 02.06.2020 um 12:18 hat Kevin Wolf geschrieben: > Am 29.05.2020 um 02:18 hat John Snow geschrieben: > > > > [...] > > > > > > > > -def qmp(self, cmd, conv_keys=True, **args): > > > -""" > > > -Invoke a QMP command and return the response dict > > > -""" > > > +

Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-06-02 Thread Kevin Wolf
Am 29.05.2020 um 02:18 hat John Snow geschrieben: > > [...] > > > > > -def qmp(self, cmd, conv_keys=True, **args): > > -""" > > -Invoke a QMP command and return the response dict > > -""" > > +@classmethod > > +def _qmp_args(cls, _conv_keys: bool = True, **ar

Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-05-28 Thread John Snow
[...] > > -def qmp(self, cmd, conv_keys=True, **args): > -""" > -Invoke a QMP command and return the response dict > -""" > +@classmethod > +def _qmp_args(cls, _conv_keys: bool = True, **args: Any) -> Dict[str, > Any]: > qmp_args = dict() >