Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-27 Thread Peter Xu
On Wed, Oct 27, 2021 at 04:30:18PM +0800, Peter Xu wrote: > On Tue, Oct 26, 2021 at 05:11:39PM +0200, Igor Mammedov wrote: > > On Fri, 22 Oct 2021 10:14:29 +0800 > > Peter Xu wrote: > > > > > Hi, Alex, > > > > > > On Thu, Oct 21, 2021 at 04:30:39PM -0600, Alex Williamson wrote: > > > > On Thu, 2

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-27 Thread Peter Xu
On Tue, Oct 26, 2021 at 05:11:39PM +0200, Igor Mammedov wrote: > On Fri, 22 Oct 2021 10:14:29 +0800 > Peter Xu wrote: > > > Hi, Alex, > > > > On Thu, Oct 21, 2021 at 04:30:39PM -0600, Alex Williamson wrote: > > > On Thu, 21 Oct 2021 18:42:59 +0800 > > > Peter Xu wrote: > > > > > > > Scan the

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-26 Thread Alex Williamson
On Tue, 26 Oct 2021 17:11:39 +0200 Igor Mammedov wrote: > On Fri, 22 Oct 2021 10:14:29 +0800 > Peter Xu wrote: > > > Hi, Alex, > > > > On Thu, Oct 21, 2021 at 04:30:39PM -0600, Alex Williamson wrote: > > > On Thu, 21 Oct 2021 18:42:59 +0800 > > > Peter Xu wrote: > > > > > > > Scan the

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-26 Thread Igor Mammedov
On Fri, 22 Oct 2021 10:14:29 +0800 Peter Xu wrote: > Hi, Alex, > > On Thu, Oct 21, 2021 at 04:30:39PM -0600, Alex Williamson wrote: > > On Thu, 21 Oct 2021 18:42:59 +0800 > > Peter Xu wrote: > > > > > Scan the pci bus to make sure there's no vfio-pci device attached before > > > vIOMMU > >

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-21 Thread Peter Xu
On Thu, Oct 21, 2021 at 02:38:54PM +0200, Eric Auger wrote: > Hi Peter, > > On 10/21/21 12:42 PM, Peter Xu wrote: > > Scan the pci bus to make sure there's no vfio-pci device attached before > > vIOMMU > > is realized. > > > > Suggested-by: Igor Mammedov > > Signed-off-by: Peter Xu > > --- > >

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-21 Thread Peter Xu
Hi, Alex, On Thu, Oct 21, 2021 at 04:30:39PM -0600, Alex Williamson wrote: > On Thu, 21 Oct 2021 18:42:59 +0800 > Peter Xu wrote: > > > Scan the pci bus to make sure there's no vfio-pci device attached before > > vIOMMU > > is realized. > > Sorry, I'm not onboard with this solution at all. >

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-21 Thread Alex Williamson
On Thu, 21 Oct 2021 18:42:59 +0800 Peter Xu wrote: > Scan the pci bus to make sure there's no vfio-pci device attached before > vIOMMU > is realized. Sorry, I'm not onboard with this solution at all. It would be really useful though if this commit log or a code comment described exactly the in

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-21 Thread Eric Auger
Hi Peter, On 10/21/21 12:42 PM, Peter Xu wrote: > Scan the pci bus to make sure there's no vfio-pci device attached before > vIOMMU > is realized. > > Suggested-by: Igor Mammedov > Signed-off-by: Peter Xu > --- > hw/i386/x86-iommu.c | 18 ++ > 1 file changed, 18 insertions(+) >

Re: [PATCH 8/8] x86-iommu: Fail early if vIOMMU specified after vfio-pci

2021-10-21 Thread Michael S. Tsirkin
On Thu, Oct 21, 2021 at 06:42:59PM +0800, Peter Xu wrote: > Scan the pci bus to make sure there's no vfio-pci device attached before > vIOMMU > is realized. > > Suggested-by: Igor Mammedov > Signed-off-by: Peter Xu > --- > hw/i386/x86-iommu.c | 18 ++ > 1 file changed, 18 inser