Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.

2020-08-25 Thread Yonggang Luo
OK, maybe convert this to python script would be a better option. Then skip this first On Tue, Aug 25, 2020 at 9:59 PM Eric Blake wrote: > On 8/25/20 4:11 AM, 罗勇刚(Yonggang Luo) wrote: > > Hi, works, msys2 sh compiled and run > > Top-formatting makes it harder to read, compared to interleaving yo

Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.

2020-08-25 Thread Eric Blake
On 8/25/20 4:11 AM, 罗勇刚(Yonggang Luo) wrote: Hi, works, msys2 sh compiled and run Top-formatting makes it harder to read, compared to interleaving your responses. msys2 sh _is_ bash, so that's not answering the question Dan asked. +++ b/scripts/undefsym.sh @@ -1,4 +1,4 @@ -#! /usr/bin/env

Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.

2020-08-25 Thread Yonggang Luo
Hi, works, msys2 sh compiled and run On Tue, Aug 25, 2020 at 4:59 PM Daniel P. Berrangé wrote: > On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyongg...@gmail.com wrote: > > From: Yonggang Luo > > > > --- > > scripts/undefsym.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > d

Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.

2020-08-25 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyongg...@gmail.com wrote: > From: Yonggang Luo > > --- > scripts/undefsym.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh > index b9ec332e95..8189308b2c 100755 > --- a/scripts/unde