Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2023-02-26 Thread Andrew Melnichenko
Hi, On Mon, Feb 20, 2023 at 11:54 AM Daniel P. Berrangé wrote: > > On Sun, Feb 19, 2023 at 06:20:59PM +0200, Andrew Melnychenko wrote: > > Helper program. Loads eBPF RSS program and maps and passes them through > > unix socket. > > Libvirt may launch this helper and pass eBPF fds to qemu virtio-

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2023-02-20 Thread Daniel P . Berrangé
On Sun, Feb 19, 2023 at 06:20:59PM +0200, Andrew Melnychenko wrote: > Helper program. Loads eBPF RSS program and maps and passes them through unix > socket. > Libvirt may launch this helper and pass eBPF fds to qemu virtio-net. > Also, libbpf dependency for now is exclusively for Linux. > Libbpf i

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-09 Thread Jason Wang
On Fri, Sep 10, 2021 at 7:44 AM Yuri Benditovich wrote: > > On Thu, Sep 9, 2021 at 4:16 AM Jason Wang wrote: > > > > On Thu, Sep 9, 2021 at 8:00 AM Yuri Benditovich > > wrote: > > > > > > On Wed, Sep 8, 2021 at 6:45 AM Jason Wang wrote: > > > > > > > > On Tue, Sep 7, 2021 at 6:40 PM Yuri Bendit

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-09 Thread Yuri Benditovich
On Thu, Sep 9, 2021 at 4:16 AM Jason Wang wrote: > > On Thu, Sep 9, 2021 at 8:00 AM Yuri Benditovich > wrote: > > > > On Wed, Sep 8, 2021 at 6:45 AM Jason Wang wrote: > > > > > > On Tue, Sep 7, 2021 at 6:40 PM Yuri Benditovich > > > wrote: > > > > > > > > On Wed, Sep 1, 2021 at 9:42 AM Jason Wa

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-08 Thread Jason Wang
On Thu, Sep 9, 2021 at 8:00 AM Yuri Benditovich wrote: > > On Wed, Sep 8, 2021 at 6:45 AM Jason Wang wrote: > > > > On Tue, Sep 7, 2021 at 6:40 PM Yuri Benditovich > > wrote: > > > > > > On Wed, Sep 1, 2021 at 9:42 AM Jason Wang wrote: > > > > > > > > > > > > 在 2021/8/31 上午1:07, Yuri Benditovic

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-08 Thread Yuri Benditovich
On Wed, Sep 8, 2021 at 6:45 AM Jason Wang wrote: > > On Tue, Sep 7, 2021 at 6:40 PM Yuri Benditovich > wrote: > > > > On Wed, Sep 1, 2021 at 9:42 AM Jason Wang wrote: > > > > > > > > > 在 2021/8/31 上午1:07, Yuri Benditovich 写道: > > > > On Fri, Aug 20, 2021 at 6:41 AM Jason Wang wrote: > > > >> >

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-07 Thread Jason Wang
On Tue, Sep 7, 2021 at 6:40 PM Yuri Benditovich wrote: > > On Wed, Sep 1, 2021 at 9:42 AM Jason Wang wrote: > > > > > > 在 2021/8/31 上午1:07, Yuri Benditovich 写道: > > > On Fri, Aug 20, 2021 at 6:41 AM Jason Wang wrote: > > >> > > >> 在 2021/7/13 下午11:37, Andrew Melnychenko 写道: > > >>> Helper progra

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-07 Thread Yuri Benditovich
On Wed, Sep 1, 2021 at 9:42 AM Jason Wang wrote: > > > 在 2021/8/31 上午1:07, Yuri Benditovich 写道: > > On Fri, Aug 20, 2021 at 6:41 AM Jason Wang wrote: > >> > >> 在 2021/7/13 下午11:37, Andrew Melnychenko 写道: > >>> Helper program. Loads eBPF RSS program and maps and passes them through > >>> unix soc

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-06 Thread Jason Wang
On Mon, Sep 6, 2021 at 11:50 PM Andrew Melnichenko wrote: > > Hi, >> >> I think it's for back-compatibility. >> >> E.g current codes works without mmap(), and user will surprise that it >> wont' work after upgrading their qemu. > > Well, the current code would require additional capabilities with

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-09-06 Thread Andrew Melnichenko
Hi, > I think it's for back-compatibility. > > E.g current codes works without mmap(), and user will surprise that it > wont' work after upgrading their qemu. > Well, the current code would require additional capabilities with "kernel.unprivileged_bpf_disabled=1", which may be possible on RedHat s

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-08-31 Thread Jason Wang
在 2021/8/31 上午1:07, Yuri Benditovich 写道: On Fri, Aug 20, 2021 at 6:41 AM Jason Wang wrote: 在 2021/7/13 下午11:37, Andrew Melnychenko 写道: Helper program. Loads eBPF RSS program and maps and passes them through unix socket. Libvirt may launch this helper and pass eBPF fds to qemu virtio-net.

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-08-31 Thread Jason Wang
在 2021/8/26 上午2:24, Andrew Melnichenko 写道: Hi, I wonder if this can be done as helper for TAP/bridge. Well, it does already, libvirt may create TAP device and pass it in command line or using getfd qmp command. E.g it's the qemu to launch those helper with set-uid. Then libvir

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-08-30 Thread Yuri Benditovich
On Fri, Aug 20, 2021 at 6:41 AM Jason Wang wrote: > > > 在 2021/7/13 下午11:37, Andrew Melnychenko 写道: > > Helper program. Loads eBPF RSS program and maps and passes them through > > unix socket. > > Libvirt may launch this helper and pass eBPF fds to qemu virtio-net. > > > I wonder if this can be d

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-08-25 Thread Andrew Melnichenko
Hi, > I wonder if this can be done as helper for TAP/bridge. > Well, it does already, libvirt may create TAP device and pass it in command line or using getfd qmp command. E.g it's the qemu to launch those helper with set-uid. > Then libvirt won't even need to care about that? Yea, we may think

Re: [PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-08-19 Thread Jason Wang
在 2021/7/13 下午11:37, Andrew Melnychenko 写道: Helper program. Loads eBPF RSS program and maps and passes them through unix socket. Libvirt may launch this helper and pass eBPF fds to qemu virtio-net. I wonder if this can be done as helper for TAP/bridge. E.g it's the qemu to launch those hel