Re: [PATCH 4/4] tcg/optimize: optimize TSTNE using smask and zmask

2024-02-29 Thread Richard Henderson
On 2/28/24 23:35, Paolo Bonzini wrote: On 2/29/24 00:10, Richard Henderson wrote: On 2/28/24 01:11, Paolo Bonzini wrote: -    /* TSTNE x,sign -> LT x,0 */ -    if (arg_is_const_val(*p2, (ctx->type == TCG_TYPE_I32 -   ? INT32_MIN : INT64_MIN))) { +    /* TSTNE x,i ->

Re: [PATCH 4/4] tcg/optimize: optimize TSTNE using smask and zmask

2024-02-29 Thread Paolo Bonzini
On 2/29/24 00:10, Richard Henderson wrote: On 2/28/24 01:11, Paolo Bonzini wrote: -    /* TSTNE x,sign -> LT x,0 */ -    if (arg_is_const_val(*p2, (ctx->type == TCG_TYPE_I32 -   ? INT32_MIN : INT64_MIN))) { +    /* TSTNE x,i -> LT x,0 if i only includes sign bit copie

Re: [PATCH 4/4] tcg/optimize: optimize TSTNE using smask and zmask

2024-02-28 Thread Richard Henderson
On 2/28/24 01:11, Paolo Bonzini wrote: -/* TSTNE x,sign -> LT x,0 */ -if (arg_is_const_val(*p2, (ctx->type == TCG_TYPE_I32 - ? INT32_MIN : INT64_MIN))) { +/* TSTNE x,i -> LT x,0 if i only includes sign bit copies */ +if (arg_is_const(*p2) && (arg_info