Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-21 Thread Laurent Vivier
Le 17/09/2022 à 13:25, Mark Cave-Ayland a écrit : Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode. Signed-off-by: Mark Cave-Ayland ---

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-20 Thread Philippe Mathieu-Daudé via
On 19/9/22 10:13, Richard Henderson wrote: On 9/18/22 00:29, Philippe Mathieu-Daudé wrote: On 17/9/22 13:25, Mark Cave-Ayland wrote: Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to hand

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-19 Thread Richard Henderson
On 9/17/22 13:25, Mark Cave-Ayland wrote: Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode. Signed-off-by: Mark Cave-Ayland --- target/m

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-19 Thread Richard Henderson
On 9/18/22 00:29, Philippe Mathieu-Daudé wrote: On 17/9/22 13:25, Mark Cave-Ayland wrote: Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-17 Thread Philippe Mathieu-Daudé via
On 17/9/22 13:25, Mark Cave-Ayland wrote: Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode. Shouldn't be safer to add the gen_exit_tb() c