Re: [PATCH 3/8] target/arm: use FIELD macro for CNTHCTL bit definitions

2024-03-04 Thread Richard Henderson
On 3/4/24 03:21, Peter Maydell wrote: On Fri, 1 Mar 2024 at 21:19, Richard Henderson wrote: On 3/1/24 08:32, Peter Maydell wrote: We prefer the FIELD macro over ad-hoc #defines for register bits; switch CNTHCTL to that style before we add any more bits. Signed-off-by: Peter Maydell --- t

Re: [PATCH 3/8] target/arm: use FIELD macro for CNTHCTL bit definitions

2024-03-04 Thread Peter Maydell
On Fri, 1 Mar 2024 at 21:19, Richard Henderson wrote: > > On 3/1/24 08:32, Peter Maydell wrote: > > We prefer the FIELD macro over ad-hoc #defines for register bits; > > switch CNTHCTL to that style before we add any more bits. > > > > Signed-off-by: Peter Maydell > > --- > > target/arm/interna

Re: [PATCH 3/8] target/arm: use FIELD macro for CNTHCTL bit definitions

2024-03-01 Thread Richard Henderson
On 3/1/24 08:32, Peter Maydell wrote: We prefer the FIELD macro over ad-hoc #defines for register bits; switch CNTHCTL to that style before we add any more bits. Signed-off-by: Peter Maydell --- target/arm/internals.h | 19 +-- target/arm/helper.c| 9 - 2 files

Re: [PATCH 3/8] target/arm: use FIELD macro for CNTHCTL bit definitions

2024-03-01 Thread Richard Henderson
On 3/1/24 08:32, Peter Maydell wrote: We prefer the FIELD macro over ad-hoc #defines for register bits; switch CNTHCTL to that style before we add any more bits. Signed-off-by: Peter Maydell --- target/arm/internals.h | 19 +-- target/arm/helper.c| 9 - 2 files c

Re: [PATCH 3/8] target/arm: use FIELD macro for CNTHCTL bit definitions

2024-03-01 Thread Philippe Mathieu-Daudé
On 1/3/24 19:32, Peter Maydell wrote: We prefer the FIELD macro over ad-hoc #defines for register bits; switch CNTHCTL to that style before we add any more bits. Signed-off-by: Peter Maydell --- target/arm/internals.h | 19 +-- target/arm/helper.c| 9 - 2 files