Re: [PATCH 3/3] tests/tcg/s390x: test signed vfmin/vfmax

2022-07-13 Thread Ilya Leoshkevich
On Wed, 2022-07-13 at 21:14 +0530, Richard Henderson wrote: > On 7/12/22 18:02, Ilya Leoshkevich wrote: > > > This works, of course.  It could be simpler using EXECUTE, to > > > store > > > just the one > > > instruction and not worry about an executable mapped page, but I > > > guess it doesn't ma

Re: [PATCH 3/3] tests/tcg/s390x: test signed vfmin/vfmax

2022-07-13 Thread Richard Henderson
On 7/12/22 18:02, Ilya Leoshkevich wrote: This works, of course.  It could be simpler using EXECUTE, to store just the one instruction and not worry about an executable mapped page, but I guess it doesn't matter. I thought about this too, but EX/EXRL operate only on the second byte, and I need

Re: [PATCH 3/3] tests/tcg/s390x: test signed vfmin/vfmax

2022-07-12 Thread Ilya Leoshkevich
On Tue, 2022-07-12 at 10:19 +0530, Richard Henderson wrote: > On 7/12/22 07:27, Ilya Leoshkevich wrote: > > +/* > > + * vfmin/vfmax code generation. > > + */ > > +extern const char vfminmax_template[]; > > +extern const int vfminmax_template_size; > > +extern const int vfminmax_offset; > > +asm(".g

Re: [PATCH 3/3] tests/tcg/s390x: test signed vfmin/vfmax

2022-07-11 Thread Richard Henderson
On 7/12/22 07:27, Ilya Leoshkevich wrote: +/* + * vfmin/vfmax code generation. + */ +extern const char vfminmax_template[]; +extern const int vfminmax_template_size; +extern const int vfminmax_offset; +asm(".globl vfminmax_template\n" +"vfminmax_template:\n" +"vl %v25,0(%r3)\n" +"vl %