Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-03 Thread Andrew Jones
On Wed, Jul 29, 2020 at 04:40:54PM +0200, Andrew Jones wrote: > > > +static inline void kvm_arm_steal_time_finalize(ARMCPU *cpu, Error > > > **errp) {} > > > > Does this stub need to report an error to the caller via errp, > > or is it a "never called but needs to exist to avoid linker errors" ?

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-03 Thread Andrew Jones
On Sat, Aug 01, 2020 at 02:00:34PM +0200, Andrew Jones wrote: > > > if (kvm_enabled()) { > > > +hwaddr pvtime_base = vms->memmap[VIRT_PVTIME].base; > > > +hwaddr pvtime_size = vms->memmap[VIRT_PVTIME].size; > > > + > > > +if (steal_time) { > > > +MemoryRegio

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-01 Thread Andrew Jones
On Fri, Jul 31, 2020 at 03:54:07PM +0100, Peter Maydell wrote: > On Sat, 11 Jul 2020 at 11:10, Andrew Jones wrote: > > We add the kvm-steal-time CPU property and implement it for machvirt. > > A tiny bit of refactoring was also done to allow pmu and pvtime to > > use the same vcpu device helper fu

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-07-31 Thread Peter Maydell
On Sat, 11 Jul 2020 at 11:10, Andrew Jones wrote: > We add the kvm-steal-time CPU property and implement it for machvirt. > A tiny bit of refactoring was also done to allow pmu and pvtime to > use the same vcpu device helper functions. > > Signed-off-by: Andrew Jones Hi; I'm forwarding a couple

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-07-29 Thread Andrew Jones
On Tue, Jul 21, 2020 at 11:46:12AM +0100, Peter Maydell wrote: > > +if (!probed) { > > +probed = true; > > +if (kvm_check_extension(kvm_state, KVM_CAP_VCPU_ATTRIBUTES)) { > > +if (!kvm_arm_create_scratch_host_vcpu(NULL, fdarray, NULL)) { > > +error_re

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-07-21 Thread Peter Maydell
On Sat, 11 Jul 2020 at 11:10, Andrew Jones wrote: > > We add the kvm-steal-time CPU property and implement it for machvirt. > A tiny bit of refactoring was also done to allow pmu and pvtime to > use the same vcpu device helper functions. > > Signed-off-by: Andrew Jones > --- > docs/system/arm/cp