Re: [PATCH 26/26] docs/devel: introduce some key concepts for QOM development

2023-06-26 Thread Paolo Bonzini
On 6/26/23 15:39, Alex Bennée wrote: There were review comments on this series that haven't been applied. Sorry I'd missed those. I've fixed that for the respin which is currently checking on CI. Still not exactly what I asked for; please remove the "The Device Class" heading (just the headin

Re: [PATCH 26/26] docs/devel: introduce some key concepts for QOM development

2023-06-26 Thread Alex Bennée
Paolo Bonzini writes: > On 6/23/23 14:21, Alex Bennée wrote: >> Using QOM correctly is increasingly important to maintaining a modern >> code base. However the current documentation skips some important >> concepts before launching into a simple example. Lets: >>- at least mention propertie

Re: [PATCH 26/26] docs/devel: introduce some key concepts for QOM development

2023-06-26 Thread Paolo Bonzini
On 6/23/23 14:21, Alex Bennée wrote: Using QOM correctly is increasingly important to maintaining a modern code base. However the current documentation skips some important concepts before launching into a simple example. Lets: - at least mention properties - mention TYPE_OBJECT and TYPE_D