Re: [PATCH 20/55] target/arm: Implement MVE VDUP

2021-06-09 Thread Richard Henderson
On 6/9/21 3:06 AM, Peter Maydell wrote: Mmm. I think some of this structure is holdover from an initial misinterpretation of the spec that all these ops looked at the predicate bit for the LS byte of the element to see if the entire element was acted upon, in which case you do need to work elemen

Re: [PATCH 20/55] target/arm: Implement MVE VDUP

2021-06-09 Thread Peter Maydell
On Wed, 9 Jun 2021 at 00:17, Richard Henderson wrote: > > On 6/7/21 9:57 AM, Peter Maydell wrote: > > +#define DO_VDUP(OP, ESIZE, TYPE, H) \ > > +void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t val) \ > > +{

Re: [PATCH 20/55] target/arm: Implement MVE VDUP

2021-06-08 Thread Richard Henderson
On 6/7/21 9:57 AM, Peter Maydell wrote: +#define DO_VDUP(OP, ESIZE, TYPE, H) \ +void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t val) \ +{ \ +TYPE *d = vd;