Re: [PATCH 2/5] vhost-user-blk: Use Error more consistently

2021-04-29 Thread Raphael Norwitz
Makes sense - I see why it makes reporting better at realize time. Thanks for the clarification. On Thu, Apr 29, 2021 at 11:26:29AM +0200, Kevin Wolf wrote: > Am 28.04.2021 um 20:08 hat Raphael Norwitz geschrieben: > > Code looks ok - question about the commit message. > > > > Acked-by: Raphael

Re: [PATCH 2/5] vhost-user-blk: Use Error more consistently

2021-04-29 Thread Kevin Wolf
Am 28.04.2021 um 20:08 hat Raphael Norwitz geschrieben: > Code looks ok - question about the commit message. > > Acked-by: Raphael Norwitz > > On Thu, Apr 22, 2021 at 07:02:18PM +0200, Kevin Wolf wrote: > > Now that vhost_user_blk_connect() is not called from an event handler > > any more, but d

Re: [PATCH 2/5] vhost-user-blk: Use Error more consistently

2021-04-28 Thread Raphael Norwitz
Code looks ok - question about the commit message. Acked-by: Raphael Norwitz On Thu, Apr 22, 2021 at 07:02:18PM +0200, Kevin Wolf wrote: > Now that vhost_user_blk_connect() is not called from an event handler > any more, but directly from vhost_user_blk_device_realize(), we don't > have to resor