Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-06 Thread Guenter Roeck
On 2/5/20 11:04 PM, Joel Stanley wrote: On Wed, 5 Feb 2020 at 17:43, Guenter Roeck wrote: On Wed, Feb 05, 2020 at 11:08:07AM +0100, Cédric Le Goater wrote: ok. we will need to model SFDP one day. Are you using the OpenBMC images or do you have your own ? I am running images built from up

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-05 Thread Joel Stanley
On Wed, 5 Feb 2020 at 17:43, Guenter Roeck wrote: > > On Wed, Feb 05, 2020 at 11:08:07AM +0100, Cédric Le Goater wrote: > > > > ok. we will need to model SFDP one day. > > > > Are you using the OpenBMC images or do you have your own ? > > > > I am running images built from upstream/stable kernel b

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-05 Thread Guenter Roeck
On Wed, Feb 05, 2020 at 11:08:07AM +0100, Cédric Le Goater wrote: > On 2/4/20 3:28 PM, Guenter Roeck wrote: > > On 2/4/20 12:53 AM, Cédric Le Goater wrote: > >> On 2/3/20 7:09 PM, Guenter Roeck wrote: > >>> Always report 6 bytes of JEDEC data. Fill remaining data with 0. > >>> > >>> For unsupported

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-05 Thread Cédric Le Goater
On 2/4/20 3:28 PM, Guenter Roeck wrote: > On 2/4/20 12:53 AM, Cédric Le Goater wrote: >> On 2/3/20 7:09 PM, Guenter Roeck wrote: >>> Always report 6 bytes of JEDEC data. Fill remaining data with 0. >>> >>> For unsupported commands, keep sending a value of 0 until the chip >>> is deselected. >>> >>>

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-04 Thread Guenter Roeck
On 2/4/20 12:53 AM, Cédric Le Goater wrote: On 2/3/20 7:09 PM, Guenter Roeck wrote: Always report 6 bytes of JEDEC data. Fill remaining data with 0. For unsupported commands, keep sending a value of 0 until the chip is deselected. Both changes avoid attempts to decode random commands. Up to no

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-04 Thread Philippe Mathieu-Daudé
On 2/4/20 9:53 AM, Cédric Le Goater wrote: On 2/3/20 7:09 PM, Guenter Roeck wrote: Always report 6 bytes of JEDEC data. Fill remaining data with 0. For unsupported commands, keep sending a value of 0 until the chip is deselected. Both changes avoid attempts to decode random commands. Up to now

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-04 Thread Philippe Mathieu-Daudé
Hi Guenter, On 2/3/20 7:09 PM, Guenter Roeck wrote: Always report 6 bytes of JEDEC data. Fill remaining data with 0. For unsupported commands, keep sending a value of 0 until the chip is deselected. Two changes, I'd rather see 2 patches. If you happen to respin they are welcome. As the split

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

2020-02-04 Thread Cédric Le Goater
On 2/3/20 7:09 PM, Guenter Roeck wrote: > Always report 6 bytes of JEDEC data. Fill remaining data with 0. > > For unsupported commands, keep sending a value of 0 until the chip > is deselected. > > Both changes avoid attempts to decode random commands. Up to now this > happened if the reported J