Re: [PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default

2021-04-30 Thread Gustavo Noronha Silva
Hey again, On Fri, Apr 30, 2021, at 5:04 AM, 'Gerd Hoffmann ' wrote: > Wouldn't it be easier to swap the bits in the modifiers variable once > instead of having lots of isSwapOptionCommandEnabled checks in the code? Good point, since a local variable is used it's definitely easier. I'll do the c

Re: [PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default

2021-04-30 Thread 'Gerd Hoffmann '
> @@ -797,12 +806,22 @@ - (bool) handleEventLocked:(NSEvent *)event > qkbd_state_key_event(kbd, Q_KEY_CODE_CTRL_R, false); > } > if (!(modifiers & NSEventModifierFlagOption)) { > -qkbd_state_key_event(kbd, Q_KEY_CODE_ALT, false); > -qkbd_state_key_event(kbd, Q_KEY

Re: [PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default

2021-04-30 Thread Markus Armbruster
gust...@noronha.eti.br writes: > From: Gustavo Noronha Silva > > On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change > swaps them around so that Alt is the key closer to the space bar and > Meta/Super > is between Control and Alt, like on non-Mac keyboards. > > It is a