Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Richard Henderson
On 2/28/22 03:36, Peter Maydell wrote: I think we should have the 128-bit atomics check in meson.build look the same as the existing one for 64-bit atomics, though, unless there's a reason why they should look different. For the 64-bit version we explicitly pass __ATOMIC_RELAXED, and we use __ato

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 13:28, Marc-André Lureau wrote: > > Hi > > On Mon, Feb 28, 2022 at 5:24 PM Peter Maydell > wrote: > > > > On Mon, 28 Feb 2022 at 12:19, wrote: > > > > > > From: Marc-André Lureau > > > > > > testfile.c: In function 'main': > > > testfile.c:5:11: error: incorrect number o

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Marc-André Lureau
Hi On Mon, Feb 28, 2022 at 5:24 PM Peter Maydell wrote: > > On Mon, 28 Feb 2022 at 12:19, wrote: > > > > From: Marc-André Lureau > > > > testfile.c: In function 'main': > > testfile.c:5:11: error: incorrect number of arguments to function > > '__atomic_load' > > 5 | y = __atomic_load

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 12:19, wrote: > > From: Marc-André Lureau > > testfile.c: In function 'main': > testfile.c:5:11: error: incorrect number of arguments to function > '__atomic_load' > 5 | y = __atomic_load(&x, 0); > | ^ > testfile.c:6:7: error: argument

Re: [PATCH 2/2] meson: fix CONFIG_ATOMIC128 check

2022-02-28 Thread Philippe Mathieu-Daudé
On 28/2/22 13:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau testfile.c: In function 'main': testfile.c:5:11: error: incorrect number of arguments to function '__atomic_load' 5 | y = __atomic_load(&x, 0); | ^ testfile.c:6:7: error: argume