Re: [PATCH 16/20] target/arm: Fix sve_zip_p vs odd vector lengths

2020-08-28 Thread Peter Maydell
On Fri, 28 Aug 2020 at 20:26, Richard Henderson wrote: > > On 8/25/20 6:49 AM, Peter Maydell wrote: > > Why is it OK to only check vd==vn etc rather than checking for > > overlap the way the old code did ? The commit message doesn't > > mention this. > > We only ever pass pred_full_reg_offset, so

Re: [PATCH 16/20] target/arm: Fix sve_zip_p vs odd vector lengths

2020-08-28 Thread Richard Henderson
On 8/25/20 6:49 AM, Peter Maydell wrote: > On Sat, 15 Aug 2020 at 02:32, Richard Henderson > wrote: >> >> Wrote too much with low-half zip (zip1) with vl % 512 != 0. >> >> Adjust all of the x + (y << s) to x | (y << s) as a style fix. >> >> Reported-by: Laurent Desnogues >> Signed-off-by: Richard

Re: [PATCH 16/20] target/arm: Fix sve_zip_p vs odd vector lengths

2020-08-25 Thread Peter Maydell
On Sat, 15 Aug 2020 at 02:32, Richard Henderson wrote: > > Wrote too much with low-half zip (zip1) with vl % 512 != 0. > > Adjust all of the x + (y << s) to x | (y << s) as a style fix. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson > --- > target/arm/sve_helper.c | 25 ++