Daniel P. Berrangé writes:
> On Thu, Sep 17, 2020 at 02:04:41PM +0200, Markus Armbruster wrote:
>> Greg Kurz writes:
>>
>> > $ git grep object_property_get_uint -- :^{include,qom/object.c} | wc -l
>> > 60
>> >
>> > Manual inspecting the output of
>> >
>> > $ git grep -W object_property_get_uint
On Thu, 17 Sep 2020 13:18:51 +0100
Daniel P. Berrangé wrote:
> On Thu, Sep 17, 2020 at 02:04:41PM +0200, Markus Armbruster wrote:
> > Greg Kurz writes:
> >
> > > $ git grep object_property_get_uint -- :^{include,qom/object.c} | wc -l
> > > 60
> > >
> > > Manual inspecting the output of
> > >
>
On Thu, Sep 17, 2020 at 02:04:41PM +0200, Markus Armbruster wrote:
> Greg Kurz writes:
>
> > $ git grep object_property_get_uint -- :^{include,qom/object.c} | wc -l
> > 60
> >
> > Manual inspecting the output of
> >
> > $ git grep -W object_property_get_uint -- :^{include,qom/object.c}
> > ...
>
Greg Kurz writes:
> On Thu, 17 Sep 2020 09:38:49 +0200
> Markus Armbruster wrote:
>
>> David Gibson writes:
>>
>> > On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote:
>> >> On Tue, 15 Sep 2020 13:58:53 +0300
>> >> Vladimir Sementsov-Ogievskiy wrote:
>> >>
>> >> > 14.09.2020 15:35, Gr
On Thu, 17 Sep 2020 09:38:49 +0200
Markus Armbruster wrote:
> David Gibson writes:
>
> > On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote:
> >> On Tue, 15 Sep 2020 13:58:53 +0300
> >> Vladimir Sementsov-Ogievskiy wrote:
> >>
> >> > 14.09.2020 15:35, Greg Kurz wrote:
> >> > > As recom
David Gibson writes:
> On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote:
>> On Tue, 15 Sep 2020 13:58:53 +0300
>> Vladimir Sementsov-Ogievskiy wrote:
>>
>> > 14.09.2020 15:35, Greg Kurz wrote:
>> > > As recommended in "qapi/error.h", add a bool return value to
>> > > spapr_add_lmbs() a
On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote:
> On Tue, 15 Sep 2020 13:58:53 +0300
> Vladimir Sementsov-Ogievskiy wrote:
>
> > 14.09.2020 15:35, Greg Kurz wrote:
> > > As recommended in "qapi/error.h", add a bool return value to
> > > spapr_add_lmbs() and spapr_add_nvdimm(), and use
On Tue, 15 Sep 2020 14:04:23 +0200
Greg Kurz wrote:
>
> I don't expect much people except David or maybe Markus to look
> at these patches actually. And anyway, it's up to David to merge
My bad, I didn't think about Philippe... :P
Thanks for the review, Philippe !
Cheers,
--
Greg
> them. But
I've dropped the SPAM mentions from the subject this time :)
On Tue, 15 Sep 2020 14:53:53 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 15.09.2020 14:43, Greg Kurz wrote:
> > On Tue, 15 Sep 2020 13:58:53 +0300
> > Vladimir Sementsov-Ogievskiy wrote:
> >
> >> 14.09.2020 15:35, Greg Kurz wrote:
>
15.09.2020 14:43, Greg Kurz wrote:
On Tue, 15 Sep 2020 13:58:53 +0300
Vladimir Sementsov-Ogievskiy wrote:
14.09.2020 15:35, Greg Kurz wrote:
As recommended in "qapi/error.h", add a bool return value to
spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead
of local_err in spapr_memory_
On Tue, 15 Sep 2020 13:58:53 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 14.09.2020 15:35, Greg Kurz wrote:
> > As recommended in "qapi/error.h", add a bool return value to
> > spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead
> > of local_err in spapr_memory_plug().
> >
> > Since ob
14.09.2020 15:35, Greg Kurz wrote:
As recommended in "qapi/error.h", add a bool return value to
spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead
of local_err in spapr_memory_plug().
Since object_property_get_uint() only returns 0 on failure, use
that as well.
Why are you sure? Can
12 matches
Mail list logo
