On 9/29/21 3:09 AM, Gerd Hoffmann wrote:
TODO: Not sure whenever "check function pointer before call" or
"function pointers to stubs" is better. Right now the patch has both
which clearly doesn't make sense. Comments on that are welcome.
I guess I don't mind either way, but we do need to pick
> > +#ifdef TCG_DIRECT_CALL
> > void tlb_flush(CPUState *cpu);
> > +#endif
>
> I'm pretty sure you can drop these ifdefs. Just because there's a regular
> declaration for a function doesn't mean a subsequent inline definition does
> not apply.
Couldn't get this work. With "static inline" I ge
On 9/28/21 7:32 AM, Gerd Hoffmann wrote:
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 608d768a4371..72e4e3b5bb89 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -160,7 +160,9 @@ void tlb_flush_page_all_cpus_synced(CPUState *src,
target_ulong addr);
On Thu, Sep 02, 2021 at 03:09:15PM +0200, Richard Henderson wrote:
> On 8/31/21 2:15 PM, Gerd Hoffmann wrote:
> > diff --git a/target/i386/helper.c b/target/i386/helper.c
> > index 533b29cb91b6..100add713c5d 100644
> > --- a/target/i386/helper.c
> > +++ b/target/i386/helper.c
> > @@ -103,7 +103,7 @
On 8/31/21 2:15 PM, Gerd Hoffmann wrote:
diff --git a/target/i386/helper.c b/target/i386/helper.c
index 533b29cb91b6..100add713c5d 100644
--- a/target/i386/helper.c
+++ b/target/i386/helper.c
@@ -103,7 +103,7 @@ void x86_cpu_set_a20(X86CPU *cpu, int a20_state)
/* when a20 is changed,
