Re: [PATCH 10/26] hw/intc/arm_gicv3_its: Use FIELD macros for DTEs

2021-12-13 Thread Alex Bennée
Peter Maydell writes: > Currently the ITS code that reads and writes DTEs uses open-coded > shift-and-mask to assemble the various fields into the 64-bit DTE > word. The names of the macros used for mask and shift values are > also somewhat inconsistent, and don't follow our usual convention >

Re: [PATCH 10/26] hw/intc/arm_gicv3_its: Use FIELD macros for DTEs

2021-12-13 Thread Philippe Mathieu-Daudé
On Sun, Dec 12, 2021 at 10:16 PM Philippe Mathieu-Daudé wrote: > On 12/11/21 20:11, Peter Maydell wrote: > > Currently the ITS code that reads and writes DTEs uses open-coded > > shift-and-mask to assemble the various fields into the 64-bit DTE > > word. The names of the macros used for mask and

Re: [PATCH 10/26] hw/intc/arm_gicv3_its: Use FIELD macros for DTEs

2021-12-12 Thread Philippe Mathieu-Daudé
On 12/11/21 20:11, Peter Maydell wrote: > Currently the ITS code that reads and writes DTEs uses open-coded > shift-and-mask to assemble the various fields into the 64-bit DTE > word. The names of the macros used for mask and shift values are > also somewhat inconsistent, and don't follow our usua

Re: [PATCH 10/26] hw/intc/arm_gicv3_its: Use FIELD macros for DTEs

2021-12-12 Thread Richard Henderson
On 12/11/21 11:11 AM, Peter Maydell wrote: Currently the ITS code that reads and writes DTEs uses open-coded shift-and-mask to assemble the various fields into the 64-bit DTE word. The names of the macros used for mask and shift values are also somewhat inconsistent, and don't follow our usual c