Re: [PATCH 1/3] osdep: Add qemu_mkdir_with_parents()

2024-12-16 Thread Daniel P . Berrangé
On Mon, Dec 16, 2024 at 04:56:33PM +, Peter Maydell wrote: > On Mon, 16 Dec 2024 at 16:14, Peter Xu wrote: > > > > QEMU uses g_mkdir_with_parents() a lot, especially in the case where the > > failure case is ignored so an abort is expected when happened. > > > > Provide a helper qemu_mkdir_wit

Re: [PATCH 1/3] osdep: Add qemu_mkdir_with_parents()

2024-12-16 Thread Peter Xu
On Mon, Dec 16, 2024 at 07:28:19PM +0200, Konstantin Kostiuk wrote: > On Mon, Dec 16, 2024 at 7:12 PM Peter Xu wrote: > > > On Mon, Dec 16, 2024 at 04:56:33PM +, Peter Maydell wrote: > > > On Mon, 16 Dec 2024 at 16:14, Peter Xu wrote: > > > > > > > > QEMU uses g_mkdir_with_parents() a lot, e

Re: [PATCH 1/3] osdep: Add qemu_mkdir_with_parents()

2024-12-16 Thread Konstantin Kostiuk
On Mon, Dec 16, 2024 at 7:12 PM Peter Xu wrote: > On Mon, Dec 16, 2024 at 04:56:33PM +, Peter Maydell wrote: > > On Mon, 16 Dec 2024 at 16:14, Peter Xu wrote: > > > > > > QEMU uses g_mkdir_with_parents() a lot, especially in the case where > the > > > failure case is ignored so an abort is e

Re: [PATCH 1/3] osdep: Add qemu_mkdir_with_parents()

2024-12-16 Thread Alex Bennée
Peter Xu writes: > QEMU uses g_mkdir_with_parents() a lot, especially in the case where the > failure case is ignored so an abort is expected when happened. > > Provide a helper qemu_mkdir_with_parents() to do that, and use it in the > two cases in qga/. To be used in more places later. > > Sign

Re: [PATCH 1/3] osdep: Add qemu_mkdir_with_parents()

2024-12-16 Thread Peter Xu
On Mon, Dec 16, 2024 at 04:56:33PM +, Peter Maydell wrote: > On Mon, 16 Dec 2024 at 16:14, Peter Xu wrote: > > > > QEMU uses g_mkdir_with_parents() a lot, especially in the case where the > > failure case is ignored so an abort is expected when happened. > > > > Provide a helper qemu_mkdir_wit

Re: [PATCH 1/3] osdep: Add qemu_mkdir_with_parents()

2024-12-16 Thread Peter Maydell
On Mon, 16 Dec 2024 at 16:14, Peter Xu wrote: > > QEMU uses g_mkdir_with_parents() a lot, especially in the case where the > failure case is ignored so an abort is expected when happened. > > Provide a helper qemu_mkdir_with_parents() to do that, and use it in the > two cases in qga/. To be used