Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-29 Thread Philippe Mathieu-Daudé
On 4/28/21 8:00 PM, Philippe Mathieu-Daudé wrote: > On 4/28/21 6:34 PM, Richard Henderson wrote: >> On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >>>   seccomp = not_found >>> -if not get_option('seccomp').auto() or have_system or have_tools >>> +if not get_option('seccomp').auto() or have_syst

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Peter Maydell
On Wed, 28 Apr 2021 at 19:02, Philippe Mathieu-Daudé wrote: > On 4/28/21 6:34 PM, Richard Henderson wrote: > > I think the test should have been > > > > if (have_system or have_tools) and > > Yes but virtiofsd is not a tool... It is a standalone binary. This is not a distinction that our build/

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 6:34 PM, Richard Henderson wrote: > On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >>   seccomp = not_found >> -if not get_option('seccomp').auto() or have_system or have_tools >> +if not get_option('seccomp').auto() or have_system or have_tools or >> not get_option('virtiofsd').auto(

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Richard Henderson
On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: seccomp = not_found -if not get_option('seccomp').auto() or have_system or have_tools +if not get_option('seccomp').auto() or have_system or have_tools or not get_option('virtiofsd').auto() seccomp = dependency('libseccomp', version: '>=2.3

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 5:06 PM, Peter Maydell wrote: > On Wed, 28 Apr 2021 at 15:55, Philippe Mathieu-Daudé > wrote: > > (cc'ing Paolo for a meson.build question below...) > >> When not explicitly select a sysemu target and building virtiofsd, >> the seccomp/cap-ng libraries are not resolved, leading to th

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

2021-04-28 Thread Peter Maydell
On Wed, 28 Apr 2021 at 15:55, Philippe Mathieu-Daudé wrote: (cc'ing Paolo for a meson.build question below...) > When not explicitly select a sysemu target and building virtiofsd, > the seccomp/cap-ng libraries are not resolved, leading to this error: > > $ configure --target-list=i386-linux-u