> Use the "let" so that it's caught at compile time.
Thanks! Fixed.
> There's a difference with origianl C version:
> >
> > In C side, qdev_get_gpio_in() family could accept a NULL handler, but
> > there's no such case in current QEMU:
> >
> > * qdev_get_gpio_in
> > * qdev_init_gpio_in_named
> >
Il ven 7 feb 2025, 09:24 Zhao Liu ha scritto:
> > Please add "let _: () = F::ASSERT_IS_SOME;", which is added by the
> > qdev_init_clock_in() patch.
> >
>
> Okay.
>
> I would add `assert!(F::is_some());` at the beginning of init_gpio_in().
>
Use the "let" so that it's caught at compile time.
Th
On Wed, Jan 29, 2025 at 11:59:04AM +0100, Paolo Bonzini wrote:
> Date: Wed, 29 Jan 2025 11:59:04 +0100
> From: Paolo Bonzini
> Subject: Re: [PATCH 04/10] rust: add bindings for gpio_{in|out}
> initialization
>
>
>
> On Sat, Jan 25, 2025 at 1:32 PM Zhao Liu wrote:
On Sat, Jan 25, 2025 at 1:32 PM Zhao Liu wrote:
+fn init_gpio_in FnCall<(&'a Self::Target, u32, u32)>>(&self,
num_lines: u32, _f: F) {
+unsafe extern "C" fn rust_irq_handler FnCall<(&'a T, u32,
u32)>>(
+opaque: *mut c_void,
+line: c_int,
+leve