Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Paolo Bonzini
On 20/01/21 13:59, Markus Armbruster wrote: Verbose please. Do you think we should delay the conversion of -M/-accel/-object to keyval until 6.2? I concurred with "it's up for discussion". I'm happy do discuss, of course. What are the boolean parameters, and is there *any* evidence of use

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/01/21 09:42, Markus Armbruster wrote: >> The alternative is to *outlaw* parameters "help" and "?" in QemuOpts. >> I'd be cool with that. > >>> My solution would be to deprecate the QMP "change vnc" command, and >>> postpone switching -vnc to qemu_opts_parse_noisily t

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Paolo Bonzini
On 20/01/21 09:42, Markus Armbruster wrote: The alternative is to *outlaw* parameters "help" and "?" in QemuOpts. I'd be cool with that. > My solution would be to deprecate the QMP "change vnc" command, and postpone switching -vnc to qemu_opts_parse_noisily to 6.2. QMP command 'change' was dep

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/01/21 16:56, Markus Armbruster wrote: >>> +if (!is_help && warn_on_flag) { >>> +warn_report("short-form boolean option '%s%s' deprecated", >>> prefix, *name); >>> +error_printf("Please use %s=%s instead\n", *name, *value);

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-19 Thread Paolo Bonzini
On 19/01/21 16:56, Markus Armbruster wrote: +if (!is_help && warn_on_flag) { +warn_report("short-form boolean option '%s%s' deprecated", prefix, *name); +error_printf("Please use %s=%s instead\n", *name, *value); +} If @warn_on_flag, we w

Re: [PATCH 03/25] qemu-option: warn for short-form boolean options

2021-01-19 Thread Markus Armbruster
Paolo Bonzini writes: > Options such as "server" or "nowait", that are commonly found in -chardev, > are sugar for "server=on" and "wait=off". This is quite surprising and > also does not have any notion of typing attached. It is even possible to > do "-device e1000,noid" and get a device with