Re: [PATCH 03/18] hw/audio: Simplify hda audio init

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 02:35:03PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote: > > No return values are used anywhere, so switch the functions to be void > > and add support for error reporting using errp for use in next patches. > > Making

Re: [PATCH 03/18] hw/audio: Simplify hda audio init

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote: > No return values are used anywhere, so switch the functions to be void > and add support for error reporting using errp for use in next patches. Making it 'void' makes sense, but I'm not sure we need the Error **errp addition, gi