Re: [PATCH 02/23] audio: fix bit-rotted code

2021-01-31 Thread Volker RĂ¼melin
#ifdef DEBUG -alsa_dump_info(req, obt, obtfmt, pdo); +alsa_dump_info(req, obt, obtfmt, apdo); #endif "if (DEBUG) { }" is a nice way to have this checked by the compiler. With "#define DEBUG 0" the compiler will optimize away the dead code, so it isn't much different to #ifdef'ed

Re: [PATCH 02/23] audio: fix bit-rotted code

2021-01-14 Thread Gerd Hoffmann
Hi, > #ifdef DEBUG > -alsa_dump_info(req, obt, obtfmt, pdo); > +alsa_dump_info(req, obt, obtfmt, apdo); > #endif "if (DEBUG) { }" is a nice way to have this checked by the compiler. With "#define DEBUG 0" the compiler will optimize away the dead code, so it isn't much different