Re: [PATCH 02/18] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-09-30 Thread Max Reitz
On 30.09.19 16:47, Maxim Levitsky wrote: > On Mon, 2019-09-30 at 14:59 +0200, Max Reitz wrote: >> On 29.09.19 18:31, Maxim Levitsky wrote: >>> On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' globally. That is not how it

Re: [PATCH 02/18] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-09-30 Thread Maxim Levitsky
On Mon, 2019-09-30 at 14:59 +0200, Max Reitz wrote: > On 29.09.19 18:31, Maxim Levitsky wrote: > > On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: > > > Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' > > > globally. That is not how it should be done; instead, they should > > >

Re: [PATCH 02/18] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-09-30 Thread Max Reitz
On 29.09.19 18:31, Maxim Levitsky wrote: > On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: >> Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' >> globally. That is not how it should be done; instead, they should >> simply set _unsupported_imgopts to compat=0.10 (compat=1.1 is th

Re: [PATCH 02/18] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-09-29 Thread Maxim Levitsky
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: > Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' > globally. That is not how it should be done; instead, they should > simply set _unsupported_imgopts to compat=0.10 (compat=1.1 is the > default anyway). > > This makes the tests