Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-07 Thread Claudio Fontana
On 12/6/22 18:09, Philippe Mathieu-Daudé wrote: > On 6/12/22 16:38, Claudio Fontana wrote: >> On 12/6/22 15:53, Claudio Fontana wrote: >>> On 5/17/21 13:11, Philippe Mathieu-Daudé wrote: Guard declarations within hwaddr.h against inclusion from user-mode emulation. To make it cl

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Richard Henderson
On 12/6/22 11:09, Philippe Mathieu-Daudé wrote: On 6/12/22 16:38, Claudio Fontana wrote: On 12/6/22 15:53, Claudio Fontana wrote: On 5/17/21 13:11, Philippe Mathieu-Daudé wrote: Guard declarations within hwaddr.h against inclusion from user-mode emulation. To make it clearer this header is sy

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Philippe Mathieu-Daudé
On 6/12/22 16:38, Claudio Fontana wrote: On 12/6/22 15:53, Claudio Fontana wrote: On 5/17/21 13:11, Philippe Mathieu-Daudé wrote: Guard declarations within hwaddr.h against inclusion from user-mode emulation. To make it clearer this header is sysemu specific, move it to the sysemu/ directory.

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Claudio Fontana
On 12/6/22 15:53, Claudio Fontana wrote: > On 5/17/21 13:11, Philippe Mathieu-Daudé wrote: >> Guard declarations within hwaddr.h against inclusion >> from user-mode emulation. >> >> To make it clearer this header is sysemu specific, >> move it to the sysemu/ directory. > > Hi Philippe, > > do we

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Peter Maydell
On Mon, 17 May 2021 at 12:16, Philippe Mathieu-Daudé wrote: > > Guard declarations within hwaddr.h against inclusion > from user-mode emulation. They're all safe, though; none of them are target-dependent. I wonder if we should move MemMapEntry somewhere else -- it's used in less than 20 files a

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Claudio Fontana
On 5/17/21 13:11, Philippe Mathieu-Daudé wrote: > Guard declarations within hwaddr.h against inclusion > from user-mode emulation. > > To make it clearer this header is sysemu specific, > move it to the sysemu/ directory. Hi Philippe, do we need include/exec/sysemu/... .h as opposed to just use

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Philippe Mathieu-Daudé
On 6/12/22 15:32, Philippe Mathieu-Daudé wrote: On 26/5/21 20:15, Richard Henderson wrote: On 5/17/21 4:11 AM, Philippe Mathieu-Daudé wrote: --- a/include/exec/hwaddr.h +++ b/include/exec/sysemu/hwaddr.h @@ -1,8 +1,9 @@   /* Define hwaddr if it exists.  */ -#ifndef HWADDR_H -#define HWADDR_H +#

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2022-12-06 Thread Philippe Mathieu-Daudé
On 26/5/21 20:15, Richard Henderson wrote: On 5/17/21 4:11 AM, Philippe Mathieu-Daudé wrote: --- a/include/exec/hwaddr.h +++ b/include/exec/sysemu/hwaddr.h @@ -1,8 +1,9 @@   /* Define hwaddr if it exists.  */ -#ifndef HWADDR_H -#define HWADDR_H +#ifndef EXEC_SYSEMU_HWADDR_H +#define EXEC_SYSEMU_

Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/

2021-05-26 Thread Richard Henderson
On 5/17/21 4:11 AM, Philippe Mathieu-Daudé wrote: --- a/include/exec/hwaddr.h +++ b/include/exec/sysemu/hwaddr.h @@ -1,8 +1,9 @@ /* Define hwaddr if it exists. */ -#ifndef HWADDR_H -#define HWADDR_H +#ifndef EXEC_SYSEMU_HWADDR_H +#define EXEC_SYSEMU_HWADDR_H +#ifndef CONFIG_USER_ONLY