Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Philippe Mathieu-Daudé
On 6/21/21 3:47 PM, Richard Henderson wrote: > On 6/21/21 5:50 AM, Philippe Mathieu-Daudé wrote: >> I notice various targets do: >> >> #ifdef CONFIG_USER_ONLY >>     return true; >> #else >> >>> +    /* Check for the dest on the same page as the start of the TB.  */ >>> +    return ((db->pc_fir

RE: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Luis Fernando Fujita Pires
From: Richard Henderson > Add a generic version of the common use_goto_tb test. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 10 ++ > accel/tcg/translator.c| 11 +++ > 2 files changed, 21 insertions(+) Reviewed-by: Luis Pires -- Luis Pires Inst

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Richard Henderson
On 6/21/21 5:50 AM, Philippe Mathieu-Daudé wrote: I notice various targets do: #ifdef CONFIG_USER_ONLY return true; #else +/* Check for the dest on the same page as the start of the TB. */ +return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0; #endif +} Is that OK to rem

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Philippe Mathieu-Daudé
Hi Richard, On 6/21/21 3:34 AM, Richard Henderson wrote: > Add a generic version of the common use_goto_tb test. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 10 ++ > accel/tcg/translator.c| 11 +++ > 2 files changed, 21 insertions(+) > > diff --

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-20 Thread Max Filippov
On Sun, Jun 20, 2021 at 6:36 PM Richard Henderson wrote: > > Add a generic version of the common use_goto_tb test. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 10 ++ > accel/tcg/translator.c| 11 +++ > 2 files changed, 21 insertions(+) Reviewed-b