Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-25 Thread Victor Toso
Hi, On Fri, Mar 25, 2022 at 11:11:23AM -0400, John Snow wrote: > On Fri, Mar 25, 2022, 8:33 AM Markus Armbruster wrote: > > > Victor Toso writes: > > > > > @hide and @soft are potential additions which fits the TODO section > > > perfectly. > > > > > > The main motivation is to avoid this whole

Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-25 Thread Victor Toso
Hi, Many thanks for the quick review! On Thu, Mar 24, 2022 at 04:34:42PM -0400, John Snow wrote: > On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote: > > > > @hide and @soft are potential additions which fits the TODO section > > perfectly. > > > > The main motivation is to avoid this whole bloc

Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-25 Thread John Snow
On Fri, Mar 25, 2022, 8:33 AM Markus Armbruster wrote: > Victor Toso writes: > > > @hide and @soft are potential additions which fits the TODO section > > perfectly. > > > > The main motivation is to avoid this whole block of comment entering > > the wrong section in the python parser. > > > > S

Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-25 Thread Markus Armbruster
Victor Toso writes: > @hide and @soft are potential additions which fits the TODO section > perfectly. > > The main motivation is to avoid this whole block of comment entering > the wrong section in the python parser. > > Signed-off-by: Victor Toso > --- > qapi/block-export.json | 10 +-

Re: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-24 Thread John Snow
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote: > > @hide and @soft are potential additions which fits the TODO section > perfectly. > > The main motivation is to avoid this whole block of comment entering > the wrong section in the python parser. > > Signed-off-by: Victor Toso > --- > qapi/b