Re: [PATCH 00/77] target/microblaze improvements

2020-08-28 Thread Edgar E. Iglesias
On Fri, 28 Aug 2020, 15:36 Richard Henderson, wrote: > On 8/27/20 10:09 AM, Edgar E. Iglesias wrote: > > It seems to be getting out of sync when getting a slave-error and the > core > > is not setup to take exceptions for slave errors. Looks like a > pre-existing > > bug where we're restoring CPU

Re: [PATCH 00/77] target/microblaze improvements

2020-08-28 Thread Richard Henderson
On 8/27/20 10:09 AM, Edgar E. Iglesias wrote: > It seems to be getting out of sync when getting a slave-error and the core > is not setup to take exceptions for slave errors. Looks like a pre-existing > bug where we're restoring CPU state without taking the exception. > The following fixes that par

Re: [PATCH 00/77] target/microblaze improvements

2020-08-28 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > > I started off thinking conversion to decodetree would be quick, > after I reviewed the mttcg patches last week. Then I realized > that this could also use conversion to the generic trans

Re: [PATCH 00/77] target/microblaze improvements

2020-08-27 Thread Edgar E. Iglesias
On Thu, Aug 27, 2020 at 04:19:44AM -0700, Richard Henderson wrote: > On 8/27/20 3:22 AM, Edgar E. Iglesias wrote: > > Thanks. Here's another issue, it seems some branches are jumping > > to the wrong address. > > > > This is a disasm from a failing case: > > > > 0xffd033a0: brlid r1

Re: [PATCH 00/77] target/microblaze improvements

2020-08-27 Thread Richard Henderson
On 8/27/20 3:22 AM, Edgar E. Iglesias wrote: > Thanks. Here's another issue, it seems some branches are jumping > to the wrong address. > > This is a disasm from a failing case: > > 0xffd033a0: brlid r15, -636 // 0xffd03124 > 0xffd033a4: or r0, r0, r0 > > 0x0

Re: [PATCH 00/77] target/microblaze improvements

2020-08-27 Thread Edgar E. Iglesias
On Thu, Aug 27, 2020 at 03:01:57AM -0700, Richard Henderson wrote: > On 8/27/20 2:11 AM, Edgar E. Iglesias wrote: > > So a first general regression is that opcode 0 no longer > > traps as an illegal instruction (seems to be treated as an > > add with all r0). > > Oops, will fix. Thanks. Here's an

Re: [PATCH 00/77] target/microblaze improvements

2020-08-27 Thread Richard Henderson
On 8/27/20 2:11 AM, Edgar E. Iglesias wrote: > So a first general regression is that opcode 0 no longer > traps as an illegal instruction (seems to be treated as an > add with all r0). Oops, will fix. r~

Re: [PATCH 00/77] target/microblaze improvements

2020-08-27 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > > I started off thinking conversion to decodetree would be quick, > after I reviewed the mttcg patches last week. Then I realized > that this could also use conversion to the generic trans

Re: [PATCH 00/77] target/microblaze improvements

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > > I started off thinking conversion to decodetree would be quick, > after I reviewed the mttcg patches last week. Then I realized > that this could also use conversion to the generic trans

Re: [PATCH 00/77] target/microblaze improvements

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > Wow, thanks for working on this Richard! I'll run some tests on it and go through the patches. Thanks, Edgar > I started off thinking conversion to decodetree would be quick, > after I