Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 18:04 hat Paolo Bonzini geschrieben: > On 11/23/22 14:45, Kevin Wolf wrote: > > I think this means that if we clean up everything, in the end we'll have > > coroutine_wrapper and coroutine_wrapper_bdrv (the fourth version not in > > the above list, but that Paolo mentioned we may w

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Paolo Bonzini
On 11/23/22 14:45, Kevin Wolf wrote: I think this means that if we clean up everything, in the end we'll have coroutine_wrapper and coroutine_wrapper_bdrv (the fourth version not in the above list, but that Paolo mentioned we may want to have). Yes, I agree. The only thing I'm unsure about is

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Kevin Wolf
Am 23.11.2022 um 12:45 hat Emanuele Giuseppe Esposito geschrieben: > > > Am 18/11/2022 um 11:57 schrieb Paolo Bonzini: > > On 11/16/22 15:07, Emanuele Giuseppe Esposito wrote: > >> Here we introduce generated_co_wrapper_simple, a simplification of > >> g_c_w that > >> only considers the case wher

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-23 Thread Emanuele Giuseppe Esposito
Am 18/11/2022 um 11:57 schrieb Paolo Bonzini: > On 11/16/22 15:07, Emanuele Giuseppe Esposito wrote: >> Here we introduce generated_co_wrapper_simple, a simplification of >> g_c_w that >> only considers the case where the caller is not in a coroutine. >> This simplifies and clarifies a lot when

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-21 Thread Emanuele Giuseppe Esposito
Ok, as I expected simple changes in a previous based-on serie provoke a cascade of changes that inevitably affect these patches too. While I strongly suggest to have an initial look at these patches because it gives an idea on what am I trying to accomplish, I would not go looking at nitpicks and

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-18 Thread Paolo Bonzini
On Fri, Nov 18, 2022 at 4:01 PM Emanuele Giuseppe Esposito wrote: > > - generated_co_wrapper_simple -> coroutine_wrapper > > - generated_co_wrapper_blk -> coroutine_wrapper_mixed > > - generated_co_wrapper -> coroutine_wrapper_mixed_bdrv > > > > ? It is not clear to me yet if you will have bdrv_*

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-18 Thread Emanuele Giuseppe Esposito
Am 18/11/2022 um 11:57 schrieb Paolo Bonzini: > On 11/16/22 15:07, Emanuele Giuseppe Esposito wrote: >> Here we introduce generated_co_wrapper_simple, a simplification of >> g_c_w that >> only considers the case where the caller is not in a coroutine. >> This simplifies and clarifies a lot when

Re: [PATCH 00/15] Protect the block layer with a rwlock: part 3

2022-11-18 Thread Paolo Bonzini
On 11/16/22 15:07, Emanuele Giuseppe Esposito wrote: Here we introduce generated_co_wrapper_simple, a simplification of g_c_w that only considers the case where the caller is not in a coroutine. This simplifies and clarifies a lot when the caller is a coroutine or not, and in the future will hope