Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-04-04 Thread Eric DeVolder
I'm back from travel and catching up. More info below. eric On 3/31/23 11:25, Igor Mammedov wrote: On Wed, 29 Mar 2023 12:47:05 -0400 "Michael S. Tsirkin" wrote: On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: On 3/29/23 00:19, Michael S. Tsirkin wrote: Hmm I don't think w

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-31 Thread Igor Mammedov
On Wed, 29 Mar 2023 12:47:05 -0400 "Michael S. Tsirkin" wrote: > On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > > > > On 3/29/23 00:19, Michael S. Tsirkin wrote: > > > Hmm I don't think we can reasonably make such a change for 8.0. > > > Seems too risky. > > > Also, I fe

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2023 at 07:32:59PM +0530, Ani Sinha wrote: > > > On Thu, 30 Mar 2023, Michael S. Tsirkin wrote: > > > On Thu, Mar 30, 2023 at 01:06:36PM +0530, Ani Sinha wrote: > > > > > > > > > On Wed, 29 Mar 2023, Michael S. Tsirkin wrote: > > > > > > > On Wed, Mar 29, 2023 at 08:14:37AM -0500

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-30 Thread Ani Sinha
On Thu, 30 Mar 2023, Michael S. Tsirkin wrote: > On Thu, Mar 30, 2023 at 01:06:36PM +0530, Ani Sinha wrote: > > > > > > On Wed, 29 Mar 2023, Michael S. Tsirkin wrote: > > > > > On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > > > > > > > > > > On 3/29/23 00:19, Michael S. Ts

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2023 at 01:06:36PM +0530, Ani Sinha wrote: > > > On Wed, 29 Mar 2023, Michael S. Tsirkin wrote: > > > On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > > > > > > > On 3/29/23 00:19, Michael S. Tsirkin wrote: > > > > Hmm I don't think we can reasonably make such

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-30 Thread Ani Sinha
On Wed, 29 Mar 2023, Michael S. Tsirkin wrote: > On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > > > > On 3/29/23 00:19, Michael S. Tsirkin wrote: > > > Hmm I don't think we can reasonably make such a change for 8.0. > > > Seems too risky. > > > Also, I feel we want to have

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-29 Thread Michael S. Tsirkin
On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > On 3/29/23 00:19, Michael S. Tsirkin wrote: > > Hmm I don't think we can reasonably make such a change for 8.0. > > Seems too risky. > > Also, I feel we want to have an internal (with "x-" prefix") flag to > > revert to old beha

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-29 Thread Eric DeVolder
On 3/29/23 00:19, Michael S. Tsirkin wrote: Hmm I don't think we can reasonably make such a change for 8.0. Seems too risky. Also, I feel we want to have an internal (with "x-" prefix") flag to revert to old behaviour, in case of breakage on some guests. and maybe we want to keep old revision

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-28 Thread Michael S. Tsirkin
Hmm I don't think we can reasonably make such a change for 8.0. Seems too risky. Also, I feel we want to have an internal (with "x-" prefix") flag to revert to old behaviour, in case of breakage on some guests. and maybe we want to keep old revision for old machine types. On Tue, Mar 28, 2023 at

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-28 Thread Eric DeVolder
I forgot to include the updated ACPI tables. I will do that as part of v2. In the meantime, I appreciate any feedback... eric On 3/28/23 10:59, Eric DeVolder wrote: The following Linux kernel change broke CPU hotplug for MADT revision less than 5. commit e2869bd7af60 ("x86/acpi/boot: Do not r