Re: [PATCH v4 4/5] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-12-01 Thread Alex Bennée
Stefan Hajnoczi writes: > [[PGP Signed Part:Undecided]] > On Wed, Nov 30, 2022 at 11:24:38AM +, Alex Bennée wrote: >> ..and use for both virtio-user-blk and virtio-user-gpio. This avoids >> the circular close by deferring shutdown due to disconnection until a >> later point. > > I thought r

Re: [PATCH v4 4/5] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2022 at 11:24:38AM +, Alex Bennée wrote: > ..and use for both virtio-user-blk and virtio-user-gpio. This avoids > the circular close by deferring shutdown due to disconnection until a > later point. virtio-user-blk already had this mechanism in place so > generalise it as a vhos

Re: [PATCH v4 4/5] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-30 Thread Stefan Hajnoczi
On Wed, Nov 30, 2022 at 11:24:38AM +, Alex Bennée wrote: > ..and use for both virtio-user-blk and virtio-user-gpio. This avoids > the circular close by deferring shutdown due to disconnection until a > later point. I thought re-entrancy was already avoided by Patch 3? > virtio-user-blk alread