Re: [PATCH v2 3/8] configure: move gettext detection to meson.build

2020-12-16 Thread Paolo Bonzini
On 16/12/20 16:27, Alex Bennée wrote: Paolo Bonzini writes: On 16/12/20 15:19, Alex Bennée wrote: Alex Bennée writes: This will allow meson to honour -Dauto_features=disabled later. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée ping Paolo, are you happy with this bit? Yes

Re: [PATCH v2 3/8] configure: move gettext detection to meson.build

2020-12-16 Thread Alex Bennée
Paolo Bonzini writes: > On 16/12/20 15:19, Alex Bennée wrote: >> >> Alex Bennée writes: >> >>> This will allow meson to honour -Dauto_features=disabled later. >>> >>> Suggested-by: Paolo Bonzini >>> Signed-off-by: Alex Bennée >> >> ping Paolo, are you happy with this bit? > > Yes, I'm so

Re: [PATCH v2 3/8] configure: move gettext detection to meson.build

2020-12-16 Thread Alex Bennée
Alex Bennée writes: > This will allow meson to honour -Dauto_features=disabled later. > > Suggested-by: Paolo Bonzini > Signed-off-by: Alex Bennée ping Paolo, are you happy with this bit? > --- > configure | 19 +++ > meson_options.txt | 2 +- > po/meson.build|

Re: [PATCH v2 3/8] configure: move gettext detection to meson.build

2020-12-16 Thread Paolo Bonzini
On 16/12/20 15:19, Alex Bennée wrote: Alex Bennée writes: This will allow meson to honour -Dauto_features=disabled later. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée ping Paolo, are you happy with this bit? Yes, I'm so happy with this and the --with-default-features parts th