Re: [PATCH] virtiofsd: Show submounts

2020-05-01 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > Currently, setup_mounts() bind-mounts the shared directory without > MS_REC. This makes all submounts disappear. > > Pass MS_REC so that the guest can see submounts again. > > Fixes: 3ca8a2b1c83eb185c232a4e87abbb65495263756 > Signed-off-by: Max Reitz Qu

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Vivek Goyal
On Thu, Apr 30, 2020 at 03:47:04PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 30, 2020 at 10:41:16AM -0400, Vivek Goyal wrote: > > On Thu, Apr 30, 2020 at 03:34:25PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Apr 30, 2020 at 03:20:13PM +0100, Dr. David Alan Gilbert wrote: > > > > * Vivek Go

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 10:41:16AM -0400, Vivek Goyal wrote: > On Thu, Apr 30, 2020 at 03:34:25PM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 30, 2020 at 03:20:13PM +0100, Dr. David Alan Gilbert wrote: > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > > On Thu, Apr 30, 2020 at 09:58:12AM +0

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Vivek Goyal
On Thu, Apr 30, 2020 at 03:34:25PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 30, 2020 at 03:20:13PM +0100, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > On Thu, Apr 30, 2020 at 09:58:12AM +0100, Dr. David Alan Gilbert wrote: > > > [..] > > > > > > Even withou

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 03:20:13PM +0100, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > On Thu, Apr 30, 2020 at 09:58:12AM +0100, Dr. David Alan Gilbert wrote: > > [..] > > > > > Even without this patch, the SLAVE stuff worked so if you start the > > > > > daemon and

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Vivek Goyal
On Thu, Apr 30, 2020 at 03:20:13PM +0100, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > On Thu, Apr 30, 2020 at 09:58:12AM +0100, Dr. David Alan Gilbert wrote: > > [..] > > > > > Even without this patch, the SLAVE stuff worked so if you start the > > > > > daemon and

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Thu, Apr 30, 2020 at 09:58:12AM +0100, Dr. David Alan Gilbert wrote: > [..] > > > > Even without this patch, the SLAVE stuff worked so if you start the > > > > daemon and *then* mount under the shared directory, the guest sees it > > > > with or without

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Vivek Goyal
On Thu, Apr 30, 2020 at 09:58:12AM +0100, Dr. David Alan Gilbert wrote: [..] > > > Even without this patch, the SLAVE stuff worked so if you start the > > > daemon and *then* mount under the shared directory, the guest sees it > > > with or without this patch. > > > > Hm, I don’t. Do you really?

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Max Reitz
On 30.04.20 11:21, Max Reitz wrote: > On 30.04.20 10:58, Dr. David Alan Gilbert wrote: >> * Max Reitz (mre...@redhat.com) wrote: >>> On 29.04.20 16:57, Dr. David Alan Gilbert wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Max Reitz (mre...@redhat.com) wrote: >> Curren

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Max Reitz
On 30.04.20 10:58, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 29.04.20 16:57, Dr. David Alan Gilbert wrote: >>> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * Max Reitz (mre...@redhat.com) wrote: > Currently, setup_mounts() bind-mounts the shared

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 29.04.20 16:57, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >> * Max Reitz (mre...@redhat.com) wrote: > >>> Currently, setup_mounts() bind-mounts the shared directory without > >>> MS_REC. This makes all subm

Re: [PATCH] virtiofsd: Show submounts

2020-04-30 Thread Max Reitz
On 29.04.20 16:57, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Max Reitz (mre...@redhat.com) wrote: >>> Currently, setup_mounts() bind-mounts the shared directory without >>> MS_REC. This makes all submounts disappear. >>> >>> Pass MS_REC so that the

Re: [PATCH] virtiofsd: Show submounts

2020-04-29 Thread Vivek Goyal
On Wed, Apr 29, 2020 at 03:57:20PM +0100, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Max Reitz (mre...@redhat.com) wrote: > > > Currently, setup_mounts() bind-mounts the shared directory without > > > MS_REC. This makes all submounts disappear. > >

Re: [PATCH] virtiofsd: Show submounts

2020-04-29 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Max Reitz (mre...@redhat.com) wrote: > > Currently, setup_mounts() bind-mounts the shared directory without > > MS_REC. This makes all submounts disappear. > > > > Pass MS_REC so that the guest can see submounts again. > > Thanks! > > >

Re: [PATCH] virtiofsd: Show submounts

2020-04-28 Thread Daniel P . Berrangé
On Tue, Apr 28, 2020 at 03:51:43PM +0100, Stefan Hajnoczi wrote: > On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > > > Currently, setup_mounts() bind-mounts the shared directory without > > > MS_REC. This makes all submounts disa

Re: [PATCH] virtiofsd: Show submounts

2020-04-28 Thread Stefan Hajnoczi
On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: > > Currently, setup_mounts() bind-mounts the shared directory without > > MS_REC. This makes all submounts disappear. > > > > Pass MS_REC so that the guest can see submounts again. >

Re: [PATCH] virtiofsd: Show submounts

2020-04-28 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 28.04.20 11:59, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 27.04.20 19:59, Dr. David Alan Gilbert wrote: > >>> * Max Reitz (mre...@redhat.com) wrote: > Currently, setup_mounts() bind-mounts the shared directory w

Re: [PATCH] virtiofsd: Show submounts

2020-04-28 Thread Max Reitz
On 28.04.20 11:59, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 27.04.20 19:59, Dr. David Alan Gilbert wrote: >>> * Max Reitz (mre...@redhat.com) wrote: Currently, setup_mounts() bind-mounts the shared directory without MS_REC. This makes all submounts dis

Re: [PATCH] virtiofsd: Show submounts

2020-04-28 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 27.04.20 19:59, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> Currently, setup_mounts() bind-mounts the shared directory without > >> MS_REC. This makes all submounts disappear. > >> > >> Pass MS_REC so that the guest can

Re: [PATCH] virtiofsd: Show submounts

2020-04-28 Thread Daniel P . Berrangé
On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: > > Currently, setup_mounts() bind-mounts the shared directory without > > MS_REC. This makes all submounts disappear. > > > > Pass MS_REC so that the guest can see submounts again. >

Re: [PATCH] virtiofsd: Show submounts

2020-04-27 Thread Max Reitz
On 27.04.20 19:59, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> Currently, setup_mounts() bind-mounts the shared directory without >> MS_REC. This makes all submounts disappear. >> >> Pass MS_REC so that the guest can see submounts again. > > Thanks! > >> Fixes: 3ca8

Re: [PATCH] virtiofsd: Show submounts

2020-04-27 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > Currently, setup_mounts() bind-mounts the shared directory without > MS_REC. This makes all submounts disappear. > > Pass MS_REC so that the guest can see submounts again. Thanks! > Fixes: 3ca8a2b1c83eb185c232a4e87abbb65495263756 Should this actually be