Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Yajun Wu
On 4/3/2024 1:10 PM, Michael Tokarev wrote: External email: Use caution opening links or attachments 02.04.2024 07:51, Yajun Wu: When vhost-user or vhost-kernel is handling virtio net datapath, qemu should not touch used ring. But with vhost-user socket reconnect scenario, in a very rare ca

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Michael Tokarev
02.04.2024 07:51, Yajun Wu: When vhost-user or vhost-kernel is handling virtio net datapath, qemu should not touch used ring. But with vhost-user socket reconnect scenario, in a very rare case (has pending kick event). VRING_USED_F_NO_NOTIFY is set by qemu in following code path: ... This issu

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 14:41, Yajun Wu wrote: On 4/2/2024 8:11 PM, Philippe Mathieu-Daudé wrote: External email: Use caution opening links or attachments Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" Ack. should not touch used

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Yajun Wu
On 4/2/2024 8:11 PM, Philippe Mathieu-Daudé wrote: External email: Use caution opening links or attachments Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" Ack. should not touch used ring. But with vhost-user socket

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Philippe Mathieu-Daudé
Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" should not touch used ring. But with vhost-user socket reconnect scenario, in a very rare case (has pending kick event). VRING_USED_F_NO_NOTIFY is set by qemu in "QEMU"

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-01 Thread Michael S. Tsirkin
On Tue, Apr 02, 2024 at 12:51:09PM +0800, Yajun Wu wrote: > When vhost-user or vhost-kernel is handling virtio net datapath, qemu > should not touch used ring. > > But with vhost-user socket reconnect scenario, in a very rare case (has > pending kick event). VRING_USED_F_NO_NOTIFY is set by qemu i