Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-21 Thread Michael S. Tsirkin
On Fri, Feb 19, 2021 at 12:21:36PM +0100, Cornelia Huck wrote: > On Tue, 16 Feb 2021 12:18:30 +0100 > Cornelia Huck wrote: > > > The virtio standard specifies that any non-transitional device must > > reject commands prior to revision setting (which we do) and else > > assume revision 0 (legacy)

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-19 Thread Cornelia Huck
On Fri, 19 Feb 2021 12:21:36 +0100 Cornelia Huck wrote: > On Tue, 16 Feb 2021 12:18:30 +0100 > Cornelia Huck wrote: > > > The virtio standard specifies that any non-transitional device must > > reject commands prior to revision setting (which we do) and else > > assume revision 0 (legacy) if th

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-19 Thread Cornelia Huck
On Tue, 16 Feb 2021 12:18:30 +0100 Cornelia Huck wrote: > The virtio standard specifies that any non-transitional device must > reject commands prior to revision setting (which we do) and else > assume revision 0 (legacy) if the driver sends a non-revision-setting > command first. We neglected to

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-18 Thread Halil Pasic
On Thu, 18 Feb 2021 14:51:09 +0100 Cornelia Huck wrote: > On Wed, 17 Feb 2021 15:39:36 +0100 > Halil Pasic wrote: > > > On Tue, 16 Feb 2021 16:54:05 +0100 > > Cornelia Huck wrote: > > > > > On Tue, 16 Feb 2021 15:19:45 +0100 [..] > > > > Exactly, so the legacy stuff is not normative, and s

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-18 Thread Cornelia Huck
On Wed, 17 Feb 2021 15:39:36 +0100 Halil Pasic wrote: > On Tue, 16 Feb 2021 16:54:05 +0100 > Cornelia Huck wrote: > > > On Tue, 16 Feb 2021 15:19:45 +0100 > > Halil Pasic wrote: > > > > > On Tue, 16 Feb 2021 12:18:30 +0100 > > > Cornelia Huck wrote: > > > > > > > The virtio standard s

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-17 Thread Halil Pasic
On Tue, 16 Feb 2021 16:54:05 +0100 Cornelia Huck wrote: > On Tue, 16 Feb 2021 15:19:45 +0100 > Halil Pasic wrote: > > > On Tue, 16 Feb 2021 12:18:30 +0100 > > Cornelia Huck wrote: > > > > > The virtio standard specifies that any non-transitional device must > > > reject commands prior to re

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-16 Thread Cornelia Huck
On Tue, 16 Feb 2021 15:19:45 +0100 Halil Pasic wrote: > On Tue, 16 Feb 2021 12:18:30 +0100 > Cornelia Huck wrote: > > > The virtio standard specifies that any non-transitional device must > > reject commands prior to revision setting (which we do) and else > > assume revision 0 (legacy) if the

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-16 Thread Halil Pasic
On Tue, 16 Feb 2021 12:18:30 +0100 Cornelia Huck wrote: > The virtio standard specifies that any non-transitional device must > reject commands prior to revision setting (which we do) and else > assume revision 0 (legacy) if the driver sends a non-revision-setting > command first. We neglected to

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-16 Thread Michael S. Tsirkin
On Tue, Feb 16, 2021 at 12:51:50PM +0100, Cornelia Huck wrote: > On Tue, 16 Feb 2021 06:40:41 -0500 > "Michael S. Tsirkin" wrote: > > > On Tue, Feb 16, 2021 at 12:18:30PM +0100, Cornelia Huck wrote: > > > The virtio standard specifies that any non-transitional device must > > > reject commands pr

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-16 Thread Cornelia Huck
On Tue, 16 Feb 2021 06:40:41 -0500 "Michael S. Tsirkin" wrote: > On Tue, Feb 16, 2021 at 12:18:30PM +0100, Cornelia Huck wrote: > > The virtio standard specifies that any non-transitional device must > > reject commands prior to revision setting (which we do) and else > > assume revision 0 (legac

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-16 Thread Michael S. Tsirkin
On Tue, Feb 16, 2021 at 12:18:30PM +0100, Cornelia Huck wrote: > The virtio standard specifies that any non-transitional device must > reject commands prior to revision setting (which we do) and else > assume revision 0 (legacy) if the driver sends a non-revision-setting > command first. We neglect

Re: [PATCH] virtio-ccw: commands on revision-less devices

2021-02-16 Thread Thomas Huth
On 16/02/2021 12.18, Cornelia Huck wrote: The virtio standard specifies that any non-transitional device must reject commands prior to revision setting (which we do) and else assume revision 0 (legacy) if the driver sends a non-revision-setting command first. We neglected to do the latter. Fortu