Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-21 Thread Mark Cave-Ayland
On 14/01/2021 10:15, Claudio Fontana wrote: On 1/14/21 10:58 AM, Mark Cave-Ayland wrote: On 14/01/2021 09:07, Claudio Fontana wrote: On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: Developer errors are better represented with assert() rather than abort(). ... "also, make the tests more strict"

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Philippe Mathieu-Daudé
On 1/14/21 11:15 AM, Claudio Fontana wrote: > On 1/14/21 10:58 AM, Mark Cave-Ayland wrote: >> On 14/01/2021 09:07, Claudio Fontana wrote: >> >>> On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: Developer errors are better represented with assert() rather than abort(). >>> >>> ... "also, make the te

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Claudio Fontana
On 1/14/21 10:58 AM, Mark Cave-Ayland wrote: > On 14/01/2021 09:07, Claudio Fontana wrote: > >> On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: >>> Developer errors are better represented with assert() rather than abort(). >> >> ... "also, make the tests more strict" >> >> I'd add this since the check

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Mark Cave-Ayland
On 14/01/2021 09:07, Claudio Fontana wrote: On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: Developer errors are better represented with assert() rather than abort(). ... "also, make the tests more strict" I'd add this since the checks have been changed sometimes in the patch to be more strict.

Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()

2021-01-14 Thread Claudio Fontana
On 1/14/21 9:33 AM, Mark Cave-Ayland wrote: > Developer errors are better represented with assert() rather than abort(). ... "also, make the tests more strict" I'd add this since the checks have been changed sometimes in the patch to be more strict. Reviewed-by: Claudio Fontana > > Signed-of